Review main Merged

43783[TASK] EXT:form - Add HTML4 / HTML5 attributes for SUBMIT to wizard

Ralf Zimmermann CR +2 V +2 Easy +32 −16 updated 10/06/15, 21:33

Commit message

Add new attributes to the wizard element SUBMIT.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Björn Jacob +1
  • Verified V +2
    • Wouter Wolters +2
    • Björn Jacob +1

Issues 1

Files 2

Review log 8

  1. Ralf Zimmermann uploaded patch set 1 10/04/15, 14:59

  2. Ralf Zimmermann wrote 10/05/15, 12:59

    Topic set to ext-form-html5
  3. Björn Jacob updated the commit message in patch set 2 10/05/15, 16:00

  4. Björn Jacob updated the commit message in patch set 3 10/06/15, 19:39

  5. Wouter Wolters voted on patch set 3 V +1 CR +1 10/06/15, 20:54

  6. Björn Jacob commented on patch set 3 CR +1 V +1 10/06/15, 21:31

    Is working as expected. Some FE elements are not rendered but this is handled in a separate issue.
  7. Wouter Wolters voted on patch set 3 V +2 CR +2 10/06/15, 21:33

  8. Wouter Wolters merged patch set 3 10/06/15, 21:33