Review main Merged

43790[TASK] EXT:form - Add HTML4 / HTML5 attributes for FILEUPLOAD to wizard

Ralf Zimmermann CR +2 V +2 Normal +42 −18 updated 10/06/15, 21:05

Commit message

Add new attributes to the wizard element FILEUPLOAD.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Björn Jacob +1
  • Verified V +2
    • Wouter Wolters +2
    • Björn Jacob +1

Issues 1

Files 2

Review log 9

  1. Ralf Zimmermann uploaded patch set 1 10/04/15, 15:28

  2. Ralf Zimmermann wrote 10/05/15, 13:00

    Topic set to ext-form-html5
  3. Björn Jacob updated the commit message in patch set 2 10/05/15, 15:58

  4. Wouter Wolters voted on patch set 2 V +1 CR +1 10/06/15, 19:27

  5. Björn Jacob updated the commit message in patch set 3 10/06/15, 19:38

  6. Wouter Wolters voted on patch set 3 V +1 CR +1 10/06/15, 20:47

  7. Björn Jacob commented on patch set 3 CR +1 V +1 10/06/15, 21:05

    Works as expected. Elements are stored and loaded properly. FE output is written accordingly. Multiple = 1 also works and is sent as well. Awesome!
  8. Wouter Wolters voted on patch set 3 V +2 CR +2 10/06/15, 21:05

  9. Wouter Wolters merged patch set 3 10/06/15, 21:05