43793[WIP][FEATURE] EXT:form - Add the element INPUT to the wizard
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 9
- typo3/sysext/core/Documentation/Changelog/master/Feature-70349-EXTform-AddTheElementINPUTToTheWizard.rst3new+27 −0
- typo3/sysext/form/Classes/Domain/Factory/JsonToTypoScript.php+5 −1
- typo3/sysext/form/Classes/Domain/Model/Json/InputJsonElement.phpnew+90 −0
- typo3/sysext/form/Classes/Utility/TypoScriptToJsonConverter.php+1 −0
- typo3/sysext/form/Classes/View/Wizard/WizardView.php+1 −0
- typo3/sysext/form/Configuration/PageTS/modWizards.ts+15 −1
- typo3/sysext/form/Resources/Public/CSS/Wizard/Wizard.css+4 −0
- typo3/sysext/form/Resources/Public/JavaScript/Wizard/Elements/Basic/Input.jsnew+123 −0
- typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Elements/Basic.js+10 −0
Review log 12
-
Ralf Zimmermann uploaded patch set 1 10/04/15, 15:50
-
Ralf Zimmermann wrote 10/05/15, 13:00
Topic set to ext-form-html5 -
Björn Jacob commented on patch set 1 10/06/15, 06:16
I really like having this new form element. But we should use it differently. Right now it's not quite clear why we are introducing this new element type. In the wizard one could set tons of attributes which make no sense this way. E.g. seeing "checked" by default is perplexing. Let's discuss this on Slack to come up with a proper integration. -
Ralf Zimmermann uploaded patch set 2 10/06/15, 11:21
-
Björn Jacob commented on patch set 2 CR -1 10/06/15, 11:24
Feature-70349-EXTform-AddTheElementINPUTToTheWizard.rst:2Remove space.Feature-70349-EXTform-AddTheElementINPUTToTheWizard.rst:9"an"Feature-70349-EXTform-AddTheElementINPUTToTheWizard.rst:12"an" -
Ralf Zimmermann uploaded patch set 3 10/06/15, 11:37
-
Björn Jacob updated the commit message in patch set 4 10/07/15, 05:47
-
Björn Jacob commented on patch set 4 CR -1 V -1 10/07/15, 05:48
I'm still not happy with the solution. We've discussed the issue and got a concept. Further work is needed. -
Björn Jacob updated the commit message in patch set 5 10/07/15, 05:48
-
Oliver Hader uploaded patch set 6 10/09/15, 00:01
-
Ralf Zimmermann abandoned the change 03/05/16, 09:31
rejected -
Björn Jacob commented on patch set 6 03/05/16, 09:31
Just a small explanation: we don't need this feature anymore or at least the way the patchset introduced it. This feature won't be part of v7. In v8 the form wizard will be rewritten from scratch. Therefore, there will be a different implementation.