Review main Merged

43805[BUGFIX] EXT:form - themeName can not be overwritten by integrator

Ralf Zimmermann CR +2 V +2 Easy +2 −0 updated 10/07/15, 17:42

Commit message

It is possible to set a new themeName for a specific form but it is not
possible to set it for the whole plugin via

plugin.tx_form.settings.registeredElements.FORM.themeName = Mytheme

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 11

  1. Ralf Zimmermann uploaded patch set 1 10/04/15, 23:10

  2. Björn Jacob voted on patch set 1 CR +1 V +1 10/07/15, 10:29

  3. Björn Jacob commented on patch set 1 10/07/15, 10:38

    I've added an example form and some TS to the issue to help testing it.
  4. Björn Jacob updated the commit message in patch set 2 10/07/15, 10:40

  5. Björn Jacob voted on patch set 2 CR +1 V +1 10/07/15, 10:40

  6. Philipp Gampe voted on patch set 2 CR +1 10/07/15, 12:25

  7. Wouter Wolters commented on patch set 2 CR -1 10/07/15, 17:27

    on it
  8. Wouter Wolters uploaded patch set 3 10/07/15, 17:30

  9. Wouter Wolters voted on patch set 3 V +1 CR +1 10/07/15, 17:31

  10. Georg Ringer voted on patch set 3 CR +2 V +2 10/07/15, 17:42

  11. Georg Ringer merged patch set 3 10/07/15, 17:42