43806[!!!][TASK] Remove TYPO3 Upload Limit
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Georg Ringer +1
- Stephan Großberndt +1
- Christian Kuhn +1
-
Verified V +2
- Benni Mack +2
- Georg Ringer +1
- Christian Kuhn +1
Issues 1
Files 7
- typo3/sysext/core/Classes/Utility/GeneralUtility.php2+3 −10
- typo3/sysext/core/Configuration/DefaultConfiguration.php+0 −1
- typo3/sysext/core/Documentation/Changelog/master/Breaking-71110-TYPO3-specificUploadLimitRemoved.rstnew+18 −0
- typo3/sysext/frontend/Configuration/TCA/fe_users.php+0 −1
- typo3/sysext/impexp/Tests/Functional/Fixtures/Extensions/impexp_group_files/Configuration/TCA/tx_impexpgroupfiles_item.php+0 −4
- typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php+2 −0
- typo3/sysext/install/Classes/SystemEnvironment/Check.php+0 −27
Review log 19
-
Benni Mack uploaded patch set 1 10/05/15, 04:51
-
Frans Saris commented on patch set 1 10/05/15, 07:38
GeneralUtility.php:3050// Revert value back to KB -
Frans Saris commented on patch set 1 10/05/15, 07:39
DataHandler.php:2229Replyyou can neglect this comment. Was not mend for the public :) -
Christian Kuhn commented on patch set 1 CR +1 10/05/15, 08:03
general +1 - upload size can be done on php level and in general i see little reason to have another option in core on top of that needs constant maintenance. -
Oliver Hader uploaded patch set 2 10/09/15, 00:08
-
Daniel Goerz commented on patch set 2 10/18/15, 09:25
+1 for removing the global setting but I am not sure about the "max_size" config for TCA field "group". Removing this is the removal of a feature to restrict editors to small files (e.g. max. 100kb) for certain records. I would keept that possibility.GeneralUtility.php:3169This should be deleted as well -
Stefan Neufeind uploaded patch set 3 10/28/15, 22:38
-
Stefan Neufeind commented on patch set 3 CR +1 10/28/15, 22:39
resolved merge-conflict due to mediace removed meanwhile. And dropped the additional line from GeneralUtility (as per comment in previous changeset) -
Stephan Großberndt commented on patch set 3 10/29/15, 07:46
Even if a general upload size of 256MB is set to allow uploads of large images for field X I'd like to keep an restriction for field Y so only files of max 2MB can be used there. That feature is removed by this patchset. -
Benni Mack commented on patch set 3 11/03/15, 06:23
Anyone care to update to patch? I'm fine keeping the limit on TCA fields and datahandler. -
Benni Mack commented on patch set 3 11/03/15, 06:24
We also need a Breaking RsT -
Benni Mack uploaded patch set 4 11/05/15, 06:22
-
Benni Mack updated the commit message in patch set 5 11/05/15, 06:23
-
Georg Ringer voted on patch set 5 CR +1 V +1 11/05/15, 09:11
-
Stephan Großberndt voted on patch set 5 CR +1 11/05/15, 09:11
-
Christian Kuhn voted on patch set 5 CR +1 V +1 11/05/15, 12:51
-
Benni Mack voted on patch set 5 CR +2 V +2 11/05/15, 13:29
-
Benni Mack merged patch set 5 11/05/15, 13:29
-
Philipp Gampe commented on patch set 6 11/05/15, 15:54
Added a follow-up to extend the breaking documentation: https://review.typo3.org/#/c/44556/
DataHandler.php:2229