Review main Merged Breaking

43806[!!!][TASK] Remove TYPO3 Upload Limit

Benni Mack CR +2 V +2 Normal +23 −43 updated 11/05/15, 15:54

Commit message

TYPO3 has a specific upload limit, that is set to 10MB by default,
but could be lower if PHP settings are not correct.

This patch removes all file upload limit restrictions while keeping
TYPO3 in line with PHP settings as all proper methods are already
used to detect the maximum upload file size.

Review

  • Code review CR +2
    • Benni Mack +2
    • Georg Ringer +1
    • Stephan Großberndt +1
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Georg Ringer +1
    • Christian Kuhn +1

Issues 1

Files 7

Review log 19

  1. Benni Mack uploaded patch set 1 10/05/15, 04:51

  2. Frans Saris commented on patch set 1 10/05/15, 07:38

    DataHandler.php:2229

    Not sure if we want to drop this. I can imagine there are use-cases where you want to

    GeneralUtility.php:3050

    // Revert value back to KB
  3. Frans Saris commented on patch set 1 10/05/15, 07:39

    DataHandler.php:2229 Reply

    you can neglect this comment. Was not mend for the public :)
  4. Christian Kuhn commented on patch set 1 CR +1 10/05/15, 08:03

    general +1 - upload size can be done on php level and in general i see little reason to have another option in core on top of that needs constant maintenance.
  5. Oliver Hader uploaded patch set 2 10/09/15, 00:08

  6. Daniel Goerz commented on patch set 2 10/18/15, 09:25

    +1 for removing the global setting but I am not sure about the "max_size" config for TCA field "group". Removing this is the removal of a feature to restrict editors to small files (e.g. max. 100kb) for certain records. I would keept that possibility.

    GeneralUtility.php:3169

    This should be deleted as well
  7. Stefan Neufeind uploaded patch set 3 10/28/15, 22:38

  8. Stefan Neufeind commented on patch set 3 CR +1 10/28/15, 22:39

    resolved merge-conflict due to mediace removed meanwhile. And dropped the additional line from GeneralUtility (as per comment in previous changeset)
  9. Stephan Großberndt commented on patch set 3 10/29/15, 07:46

    Even if a general upload size of 256MB is set to allow uploads of large images for field X I'd like to keep an restriction for field Y so only files of max 2MB can be used there. That feature is removed by this patchset.
  10. Benni Mack commented on patch set 3 11/03/15, 06:23

    Anyone care to update to patch? I'm fine keeping the limit on TCA fields and datahandler.
  11. Benni Mack commented on patch set 3 11/03/15, 06:24

    We also need a Breaking RsT
  12. Benni Mack uploaded patch set 4 11/05/15, 06:22

  13. Benni Mack updated the commit message in patch set 5 11/05/15, 06:23

  14. Georg Ringer voted on patch set 5 CR +1 V +1 11/05/15, 09:11

  15. Stephan Großberndt voted on patch set 5 CR +1 11/05/15, 09:11

  16. Christian Kuhn voted on patch set 5 CR +1 V +1 11/05/15, 12:51

  17. Benni Mack voted on patch set 5 CR +2 V +2 11/05/15, 13:29

  18. Benni Mack merged patch set 5 11/05/15, 13:29

  19. Philipp Gampe commented on patch set 6 11/05/15, 15:54

    Added a follow-up to extend the breaking documentation: https://review.typo3.org/#/c/44556/