Review main Merged

43826[TASK] Call explicit render() on icon objects

Frank Nägler CR +2 V +2 Hard +351 −351 updated 01/09/19, 20:56

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Daniel Goerz +1
  • Verified V +2
    • Wouter Wolters +2
    • Daniel Goerz +1

Issues 1

Files 76

Show 56 more files

Review log 8

  1. Frank Nägler uploaded patch set 1 10/05/15, 18:30

  2. Wouter Wolters voted on patch set 2 V +1 CR +1 01/09/19, 20:56

  3. Daniel Goerz voted on patch set 2 CR +1 V +1 01/09/19, 20:56

  4. Wouter Wolters voted on patch set 2 V +2 CR +2 01/09/19, 20:56

  5. Wouter Wolters merged patch set 2 01/09/19, 20:56

  6. Mathias Schreiber commented on patch set 3 01/09/19, 20:56

    can we revert this? I am touching ALL icons anyways right now and this change broke all my work of the day.
  7. Tymoteusz Motylewski commented on patch set 3 01/09/19, 20:56

    I don't get the reason we're doing it. Icon object has __toString() implemented, so I don't get the benefit of calling it explicitly? The code looked much better without calling render.
  8. Josef Glatz updated the commit message in patch set 2 01/09/19, 20:56