43826[TASK] Call explicit render() on icon objects
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Daniel Goerz +1
-
Verified V +2
- Wouter Wolters +2
- Daniel Goerz +1
Issues 1
Files 76
- typo3/sysext/backend/Classes/Backend/ToolbarItems/ClearCacheToolbarItem.php+3 −3
- typo3/sysext/backend/Classes/Backend/ToolbarItems/ShortcutToolbarItem.php+2 −2
- typo3/sysext/backend/Classes/Backend/ToolbarItems/SystemInformationToolbarItem.php+1 −1
- typo3/sysext/backend/Classes/ClickMenu/ClickMenu.php+2 −2
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php+4 −4
- typo3/sysext/backend/Classes/ContextMenu/AbstractContextMenuDataProvider.php+1 −1
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php+1 −1
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php+6 −6
- typo3/sysext/backend/Classes/Controller/ContentElement/MoveElementController.php+3 −3
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+2 −2
- typo3/sysext/backend/Classes/Controller/File/CreateFolderController.php+2 −2
- typo3/sysext/backend/Classes/Controller/File/EditFileController.php+4 −4
- typo3/sysext/backend/Classes/Controller/File/FileUploadController.php+2 −2
- typo3/sysext/backend/Classes/Controller/File/RenameFileController.php+2 −2
- typo3/sysext/backend/Classes/Controller/File/ReplaceFileController.php+2 −2
- typo3/sysext/backend/Classes/Controller/Wizard/RteController.php+5 −5
- typo3/sysext/backend/Classes/Controller/Wizard/TableController.php+4 −4
- typo3/sysext/backend/Classes/Controller/BackendLayoutWizardController.php+3 −3
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+11 −11
- typo3/sysext/backend/Classes/Controller/FileSystemNavigationFrameController.php+1 −1
Show 56 more files
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+7 −7
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+11 −11
- typo3/sysext/backend/Classes/Controller/PageTreeNavigationController.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/FlexFormContainerContainer.php+4 −4
- typo3/sysext/backend/Classes/Form/Container/FlexFormSectionContainer.php+2 −2
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+4 −4
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php+11 −11
- typo3/sysext/backend/Classes/Form/Container/SingleFieldContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/AbstractFormElement.php+7 −7
- typo3/sysext/backend/Classes/Form/Element/InputTextElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/SelectSingleBoxElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Wizard/SuggestWizard.php+1 −1
- typo3/sysext/backend/Classes/History/RecordHistory.php+3 −3
- typo3/sysext/backend/Classes/RecordList/AbstractRecordList.php+2 −2
- typo3/sysext/backend/Classes/RecordList/ElementBrowserRecordList.php+1 −1
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php+4 −4
- typo3/sysext/backend/Classes/Tree/Pagetree/Commands.php+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+4 −4
- typo3/sysext/backend/Classes/View/PageLayoutView.php+16 −16
- typo3/sysext/backend/Classes/View/PageTreeView.php+1 −1
- typo3/sysext/belog/Classes/ViewHelpers/HistoryEntryViewHelper.php+1 −1
- typo3/sysext/beuser/Classes/Controller/PermissionAjaxController.php+7 −7
- typo3/sysext/beuser/Classes/ViewHelpers/RemoveUserViewHelper.php+1 −1
- typo3/sysext/compatibility6/Classes/Controller/Wizard/FormsController.php+10 −10
- typo3/sysext/core/Classes/Database/QueryView.php+3 −3
- typo3/sysext/core/Classes/TimeTracker/TimeTracker.php+1 −1
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php+2 −2
- typo3/sysext/documentation/Classes/Slots/ExtensionManager.php+3 −3
- typo3/sysext/extensionmanager/Classes/ViewHelpers/DownloadExtensionDataViewHelper.php+1 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/RemoveExtensionViewHelper.php+3 −3
- typo3/sysext/feedit/Classes/FrontendEditPanel.php+9 −9
- typo3/sysext/filelist/Classes/Controller/FileListController.php+2 −2
- typo3/sysext/filelist/Classes/FileList.php+26 −26
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Buttons/IconViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PageInfoViewHelper.php+1 −1
- typo3/sysext/form/Classes/View/Wizard/WizardView.php+1 −1
- typo3/sysext/frontend/Classes/Controller/TranslationStatusController.php+6 −6
- typo3/sysext/frontend/Classes/View/AdminPanelView.php+7 −7
- typo3/sysext/func/Classes/Controller/PageFunctionsController.php+1 −1
- typo3/sysext/impexp/Classes/Controller/ImportExportController.php+2 −2
- typo3/sysext/impexp/Classes/ImportExport.php+5 −5
- typo3/sysext/info_pagetsconfig/Classes/Controller/InfoPageTyposcriptConfigController.php+2 −2
- typo3/sysext/linkvalidator/Classes/Report/LinkValidatorReport.php+1 −1
- typo3/sysext/opendocs/Classes/Backend/ToolbarItems/OpendocsToolbarItem.php+2 −2
- typo3/sysext/recordlist/Classes/Browser/ElementBrowser.php+11 −11
- typo3/sysext/recordlist/Classes/RecordList/AbstractDatabaseRecordList.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+53 −53
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+16 −16
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+1 −1
- typo3/sysext/sys_action/Classes/ActionTask.php+4 −4
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateInformationModuleFunctionController.php+2 −2
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php+7 −7
- typo3/sysext/version/Classes/ClickMenu/VersionClickMenu.php+1 −1
- typo3/sysext/version/Classes/Controller/VersionModuleController.php+10 −10
- typo3/sysext/version/Classes/View/VersionView.php+2 −2
Review log 8
-
Frank Nägler uploaded patch set 1 10/05/15, 18:30
-
Wouter Wolters voted on patch set 2 V +1 CR +1 01/09/19, 20:56
-
Daniel Goerz voted on patch set 2 CR +1 V +1 01/09/19, 20:56
-
Wouter Wolters voted on patch set 2 V +2 CR +2 01/09/19, 20:56
-
Wouter Wolters merged patch set 2 01/09/19, 20:56
-
Mathias Schreiber commented on patch set 3 01/09/19, 20:56
can we revert this? I am touching ALL icons anyways right now and this change broke all my work of the day. -
Tymoteusz Motylewski commented on patch set 3 01/09/19, 20:56
I don't get the reason we're doing it. Icon object has __toString() implemented, so I don't get the benefit of calling it explicitly? The code looked much better without calling render. -
Josef Glatz updated the commit message in patch set 2 01/09/19, 20:56