Review main Merged

43837[BUGFIX] displayCond IN operator doesn't work like documented

Thomas Maroschik CR +2 V +2 Easy +25 −5 updated 10/08/15, 15:57

Commit message

The FormEngine refactoring changed the representation
of field values, so that select boxes are now arrays.
The condition evaluation cannot handle those values as
prior to the refactoring and following the documentation.

This patch changes the behavior to follow strictly the
documentation. The = operator now compares only the first
element in case of an array. The IN operator compares two
potential lists for any match.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Morton Jonuschat +1
  • Verified V +2
    • Christian Kuhn +2
    • Morton Jonuschat +1

Files 2

Review log 6

  1. Thomas Maroschik uploaded patch set 1 10/05/15, 21:00

  2. Christian Kuhn voted on patch set 1 CR +1 10/05/15, 21:03

  3. Christian Kuhn commented on patch set 1 10/05/15, 21:03

    good on reading already, will give it a real review later.
  4. Morton Jonuschat voted on patch set 1 CR +1 V +1 10/08/15, 15:41

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 10/08/15, 15:56

  6. Christian Kuhn merged patch set 1 10/08/15, 15:57