Review main Merged

43861[TASK] Enforce optimized composer autoloader

Helmut Hummel CR +2 V +2 Easy +2 −1 updated 12/17/15, 11:10

Commit message

The optimized autoload generation gives a huge benefit in performance.
Let people participate from this benefit even if they do not know about it.

Add this option in composer.json, so that this step cannot be forgotten when
creating distribution builds.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 2

Review log 6

  1. Helmut Hummel uploaded patch set 1 10/06/15, 14:34

  2. Markus Klein voted on patch set 1 CR +1 V +1 10/06/15, 14:36

  3. Wouter Wolters voted on patch set 1 V +2 CR +2 10/06/15, 14:38

  4. Wouter Wolters merged patch set 1 10/06/15, 14:38

  5. Simon Schaufelberger commented on patch set 2 12/17/15, 00:37

    I wonder, is it necessary to keep the composer.lock file in the git repo?
  6. Markus Klein commented on patch set 2 12/17/15, 11:10

    @Simon: Sent you some links on Slack