43863[TASK] Read manifest for class alias files
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Wouter Wolters +1
- Andreas Kienast +1
- Nicole Hummel +1
-
Verified V +2
- Helmut Hummel +2
- Wouter Wolters +1
- Andreas Kienast +1
- Nicole Hummel +1
Issues 1
Files 5
- typo3/sysext/core/Classes/Core/ClassLoadingInformationGenerator.php+24 −11
- typo3/sysext/core/Tests/Unit/Core/Fixtures/test_extension/Migrations/Code/ClassAliasMap.phpnew+5 −0
- typo3/sysext/core/Tests/Unit/Core/Fixtures/test_extension/Migrations/Code/WrongClassAliasMap.phpnew+1 −0
- typo3/sysext/core/Tests/Unit/Core/Fixtures/test_extension/Resources/PHP/ClassAliasMap.phpnew+5 −0
- typo3/sysext/core/Tests/Unit/Core/ClassLoadingInformationGeneratorTest.php1+121 −17
Review log 26
Show 1 earlier messages
-
Helmut Hummel uploaded patch set 1 10/06/15, 14:53
-
Helmut Hummel commented on patch set 1 CR -1 10/06/15, 14:55
tests need to be added for that -
Markus Klein commented on patch set 1 CR +1 10/06/15, 15:07
Nice! So no ClassAliasMap.php is needed anymore actually, since new extensions should/must provide a composer.json anyway and all that info can go there. -
Nicole Hummel commented on patch set 1 10/06/15, 15:16
@Markus: the changes done so far are to not enforce a composer.json for extensions as the manifest can come from ext_emconf.php as well -
Markus Klein commented on patch set 1 10/06/15, 16:08
@Nicole: Yes I know, but honestly, I would embrace using composer.json for all exts as it helps the class loader and enables usage via composer. So I consider it a "soft" must have. ;-) -
Nicole Hummel uploaded patch set 2 10/06/15, 17:02
-
Nicole Hummel commented on patch set 2 CR +1 V +1 10/06/15, 17:03
Added unit tests -
Nicole Hummel commented on patch set 2 V -1 10/06/15, 17:05
Failing tests on execution of whole test suit -
Nicole Hummel uploaded patch set 3 10/06/15, 18:57
-
Nicole Hummel voted on patch set 3 CR +1 V +1 10/06/15, 18:57
-
Nicole Hummel uploaded patch set 4 10/06/15, 19:52
-
Nicole Hummel voted on patch set 4 CR +1 V +1 10/06/15, 19:53
-
Helmut Hummel uploaded patch set 5 10/06/15, 20:09
-
Helmut Hummel uploaded patch set 6 10/06/15, 20:15
-
Helmut Hummel uploaded patch set 7 10/06/15, 20:18
-
Nicole Hummel voted on patch set 7 CR +1 V +1 10/06/15, 20:20
-
Wouter Wolters commented on patch set 7 10/06/15, 21:58
One failure for me: 1) TYPO3\CMS\Core\Tests\Unit\Core\ClassLoadingInformationGeneratorTest::buildClassAliasMapForPackageReturnsClassAliasMapForComposerManifestInformation Failed asserting that two arrays are equal. --- Expected +++ Actual @@ @@ Array ( 'aliasToClassNameMapping' => Array ( - 'foo' => 'TYPO3\CMS\Core\Tests\Unit\Cor...P\Test' - 'bar' => 'TYPO3\CMS\Core\Tests\Unit\Cor...stFile' ) 'classNameToAliasMapping' => Array ( - 'TYPO3\CMS\Core\Tests\Unit\Core\Fixtures\test_extension\Resources\PHP\Test' => Array (...) - 'TYPO3\CMS\Core\Tests\Unit\Core\Fixtures\test_extension\Resources\PHP\AnotherTestFile' => Array (...) ) ) -
Nicole Hummel commented on patch set 7 10/06/15, 23:04
@Wouter: Have tested with PHP 5.5. and 5.6 and don't get any error. Can you maybe step into debugging the problem for you? -
Wouter Wolters commented on patch set 7 10/07/15, 07:49
will try to debug later today. -
Andreas Kienast commented on patch set 7 V -1 10/07/15, 07:52
I can confirm the same failed unit test. -
Nicole Hummel uploaded patch set 8 10/07/15, 08:06
-
Andreas Kienast voted on patch set 8 CR +1 V +1 10/07/15, 08:07
-
Wouter Wolters commented on patch set 8 V +1 CR +1 10/07/15, 08:21
No failures anymore. -
Helmut Hummel commented on patch set 8 CR +2 V +2 10/07/15, 14:42
ClassLoadingInformationGeneratorTest.php:156ahhhh. good point :) -
Nicole Hummel voted on patch set 8 CR +1 V +1 10/07/15, 14:43
-
Helmut Hummel merged patch set 8 10/07/15, 14:44