Review main Merged

43870[TASK] Use ModuleTemplate API for ext:beuser

Michael Oehlhof CR +2 V +2 Hard +266 −121 updated 04/15/20, 12:51

Commit message

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Daniel Goerz +1
  • Verified V +2
    • Stefan Neufeind +2
    • Daniel Goerz +1

Issues 1

Files 11

Review log 25

  1. Michael Oehlhof uploaded patch set 1 10/06/15, 19:13

  2. Michael Oehlhof commented on patch set 1 V -1 10/06/15, 22:10

    Some errors to be fixed.
  3. Michael Oehlhof uploaded patch set 2 10/06/15, 22:25

  4. Michael Oehlhof wrote 10/06/15, 22:42

    Topic set to ModuleTemplateApi
  5. Helmut Hummel commented on patch set 2 10/08/15, 17:09

    Default.html:1

    I guess this misses the includeRequireJsModules="{0: 'TYPO3/CMS/Backend/Modal', 1: 'TYPO3/CMS/Beuser/BackendUserListing'} part, right?
  6. Helmut Hummel commented on patch set 2 10/08/15, 17:10

    Permission.html:1

    same here
  7. Michael Oehlhof uploaded patch set 3 10/08/15, 23:38

  8. Michael Oehlhof uploaded patch set 4 10/08/15, 23:58

  9. Mathias Schreiber commented on patch set 4 CR -1 V -1 10/09/15, 08:00

    BE Groups View misses "Add Button". Apart from that, it works brilliant
  10. Michael Oehlhof commented on patch set 4 10/09/15, 11:19

    Will fix it this evening.
  11. Michael Oehlhof uploaded patch set 5 10/09/15, 16:47

  12. Michael Oehlhof commented on patch set 5 10/09/15, 16:49

    Fixed little typo in the controller name ...
  13. Michael Oehlhof uploaded patch set 6 10/13/15, 13:36

  14. Stefan Neufeind voted on patch set 6 CR +1 V +1 10/13/15, 13:44

  15. Daniel Goerz commented on patch set 6 10/13/15, 13:49

    BackendUserActionController.php:50

    @return void

    BackendUserActionController.php:65

    @return void

    BackendUserActionController.php:131

    ===

    BackendUserActionController.php:132

    ===

    BackendUserActionController.php:144

    ===

    BackendUserActionController.php:155

    ===

    BackendUserActionController.php:166

    addUserGroupButton :)
  16. Wouter Wolters commented on patch set 6 10/13/15, 13:50

    BackendUserActionController.php:36

    string
  17. Stefan Neufeind commented on patch set 6 CR 0 10/13/15, 13:57

    BackendUserActionController.php:50 Reply

    Do we demand them? Or did we say we opt to leave "return void" out. (Does a PSR, CGL or the like demand them?)
  18. Daniel Goerz commented on patch set 6 10/13/15, 14:01

    BackendUserActionController.php:50 Reply

  19. Stefan Neufeind commented on patch set 6 CR -1 10/13/15, 14:03

    I'll take care of the comments
  20. Stefan Neufeind uploaded patch set 7 10/13/15, 14:07

  21. Stefan Neufeind voted on patch set 7 CR +1 V +1 10/13/15, 14:07

  22. Daniel Goerz voted on patch set 7 CR +1 V +1 10/13/15, 14:14

  23. Stefan Neufeind voted on patch set 7 CR +2 V +2 10/13/15, 16:38

  24. Stefan Neufeind merged patch set 7 10/13/15, 16:38

  25. Oliver Hader commented on patch set 8 04/15/20, 12:51

    Post -1 (sure, it was 2015 - but just stumbled over this one)

    Default.html:1 Unresolved

    At least BackendUserListing is missing... probable Modals are not working anymore (or have not been used at all)...