43870[TASK] Use ModuleTemplate API for ext:beuser
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Daniel Goerz +1
-
Verified V +2
- Stefan Neufeind +2
- Daniel Goerz +1
Issues 1
Files 11
- typo3/sysext/beuser/Classes/Controller/BackendUserActionController.php10new+207 −0
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php+40 −13
- typo3/sysext/beuser/Classes/Controller/BackendUserGroupController.php+1 −7
- typo3/sysext/beuser/Resources/Private/Layouts/Default.html2+5 −33
- typo3/sysext/beuser/Resources/Private/Layouts/Permission.html1+13 −38
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Compare.html+0 −4
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Index.html+0 −4
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Online.html+0 −3
- typo3/sysext/beuser/Resources/Private/Templates/BackendUserGroup/Index.html+0 −4
- typo3/sysext/beuser/Resources/Private/Templates/Permission/Edit.html+0 −9
- typo3/sysext/beuser/Resources/Private/Templates/Permission/Index.html+0 −6
Review log 25
-
Michael Oehlhof uploaded patch set 1 10/06/15, 19:13
-
Michael Oehlhof commented on patch set 1 V -1 10/06/15, 22:10
Some errors to be fixed. -
Michael Oehlhof uploaded patch set 2 10/06/15, 22:25
-
Michael Oehlhof wrote 10/06/15, 22:42
Topic set to ModuleTemplateApi -
Helmut Hummel commented on patch set 2 10/08/15, 17:09
Default.html:1I guess this misses the includeRequireJsModules="{0: 'TYPO3/CMS/Backend/Modal', 1: 'TYPO3/CMS/Beuser/BackendUserListing'} part, right? -
Helmut Hummel commented on patch set 2 10/08/15, 17:10
Permission.html:1same here -
Michael Oehlhof uploaded patch set 3 10/08/15, 23:38
-
Michael Oehlhof uploaded patch set 4 10/08/15, 23:58
-
Mathias Schreiber commented on patch set 4 CR -1 V -1 10/09/15, 08:00
BE Groups View misses "Add Button". Apart from that, it works brilliant -
Michael Oehlhof commented on patch set 4 10/09/15, 11:19
Will fix it this evening. -
Michael Oehlhof uploaded patch set 5 10/09/15, 16:47
-
Michael Oehlhof commented on patch set 5 10/09/15, 16:49
Fixed little typo in the controller name ... -
Michael Oehlhof uploaded patch set 6 10/13/15, 13:36
-
Stefan Neufeind voted on patch set 6 CR +1 V +1 10/13/15, 13:44
-
Daniel Goerz commented on patch set 6 10/13/15, 13:49
BackendUserActionController.php:50@return voidBackendUserActionController.php:65@return voidBackendUserActionController.php:131===BackendUserActionController.php:132===BackendUserActionController.php:144===BackendUserActionController.php:155===BackendUserActionController.php:166addUserGroupButton :) -
Wouter Wolters commented on patch set 6 10/13/15, 13:50
BackendUserActionController.php:36string -
Stefan Neufeind commented on patch set 6 CR 0 10/13/15, 13:57
BackendUserActionController.php:50ReplyDo we demand them? Or did we say we opt to leave "return void" out. (Does a PSR, CGL or the like demand them?) -
Daniel Goerz commented on patch set 6 10/13/15, 14:01
BackendUserActionController.php:50Replyhttps://docs.typo3.org/typo3cms/CodingGuidelinesReference/PhpFileFormatting/UsingPhpdoc/Index.html says "Use @return void when a function does not return a value" -
Stefan Neufeind commented on patch set 6 CR -1 10/13/15, 14:03
I'll take care of the comments -
Stefan Neufeind uploaded patch set 7 10/13/15, 14:07
-
Stefan Neufeind voted on patch set 7 CR +1 V +1 10/13/15, 14:07
-
Daniel Goerz voted on patch set 7 CR +1 V +1 10/13/15, 14:14
-
Stefan Neufeind voted on patch set 7 CR +2 V +2 10/13/15, 16:38
-
Stefan Neufeind merged patch set 7 10/13/15, 16:38
-
Oliver Hader commented on patch set 8 04/15/20, 12:51
Post -1 (sure, it was 2015 - but just stumbled over this one)Default.html:1UnresolvedAt least BackendUserListing is missing... probable Modals are not working anymore (or have not been used at all)...