Review main Merged

43875[BUGFIX] Doctype set to html5 should not render xmlns attribute

Georg Ringer CR +2 V +2 Easy +2 −0 updated 10/08/15, 18:39

Commit message

If the doctype is explicitly set to html5, the attribute xmlns
should still not be rendered.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 7

  1. Georg Ringer uploaded patch set 1 10/06/15, 21:58

  2. Wouter Wolters updated the commit message in patch set 2 10/06/15, 21:59

  3. Wouter Wolters voted on patch set 2 CR +1 10/06/15, 21:59

  4. Benni Mack voted on patch set 2 CR +2 V +1 10/07/15, 05:00

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 10/08/15, 18:37

  6. Benni Mack voted on patch set 2 V +2 10/08/15, 18:39

  7. Benni Mack merged patch set 2 10/08/15, 18:39