Review main Merged

43883[FEATURE] Add TCA autocomplete setting for input fields

Zsolt Molnar CR +2 V +2 Easy +34 −4 updated 10/08/15, 18:27

Commit message

This patch adds an additional TCA configuration for input fields to
switch on or off auto completion. This is used for username and password
fields for frontend and backend users.

Review

  • Code review CR +2
    • Benni Mack +2
    • Georg Ringer +1
    • Andreas Kienast +1
    • Nicole Hummel +1
  • Verified V +2
    • Benni Mack +2
    • Georg Ringer +1
    • Nicole Hummel +1

Issues 1

Files 5

Review log 11

  1. Zsolt Molnar uploaded patch set 1 10/07/15, 10:55

  2. Nicole Hummel commented on patch set 1 CR -1 10/07/15, 11:02

    IMHO this should be a TCA option which can be set for any input field. Will push an update ASAP
  3. Nicole Hummel uploaded patch set 2 10/07/15, 12:55

  4. Markus Klein commented on patch set 2 10/07/15, 13:09

    be_users.php:41

    use boolean please, FALSE
  5. Nicole Hummel uploaded patch set 3 10/07/15, 13:35

  6. Nicole Hummel voted on patch set 3 CR +1 V +1 10/07/15, 13:35

  7. Andreas Kienast voted on patch set 3 CR +1 10/07/15, 13:36

  8. Mathias Brodala commented on patch set 3 10/07/15, 13:44

    Feature-70126-IntroduceTcaOptionToAddAutocompleteAttributeToInputFields.rst:8

    Maybe "client-side auto completion" to avoid confusion.
  9. Georg Ringer voted on patch set 3 CR +1 V +1 10/07/15, 17:51

  10. Benni Mack commented on patch set 3 CR +2 V +2 10/08/15, 18:27

    ready to merge.
  11. Benni Mack merged patch set 3 10/08/15, 18:27