Review main Merged

43884[BUGFIX] EXT:form - Wrong attribute handling for attributes in wizard

Sebastian Wagner CR +2 V +2 Easy +31 −9 updated 10/08/15, 16:20

Commit message

Introduce ValueCheckbox to extend Checkbox that returns inputValue when
retrieving its value.

The xtype "typo3-form-wizard-valuecheckbox" is used for the following
attributes:
autofocus, checked, disabled, hidden, multiple, novalidate, readonly,
required and selected

The stored "TypoScript" contains inputValue and restores correct
checking when opening the wizard again.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Björn Jacob +1
  • Verified V +2
    • Christian Kuhn +2
    • Björn Jacob +1

Issues 1

Files 3

Review log 11

  1. Sebastian Wagner uploaded patch set 1 10/07/15, 11:09

  2. Björn Jacob commented on patch set 1 CR -1 10/07/15, 11:12

    Ext.ux.form.ValueCheckbox.js:7

    Please remove whitespace.

    Ext.ux.form.ValueCheckbox.js:16

    Please remove comment.
  3. Sebastian Wagner uploaded patch set 2 10/07/15, 11:48

  4. Björn Jacob updated the commit message in patch set 3 10/07/15, 12:10

  5. Björn Jacob commented on patch set 3 CR -1 10/07/15, 12:32

    Attributes.js:279

    This one is missing the according configuration.
  6. Sebastian Wagner uploaded patch set 4 10/07/15, 12:38

  7. Björn Jacob updated the commit message in patch set 5 10/07/15, 12:40

  8. Björn Jacob commented on patch set 5 CR +1 V +1 10/07/15, 12:44

    Awesome. Works for me. The selected attribute is not rendered in the frontend but this is a different issue and does not belong to this patchset.
  9. Björn Jacob commented on patch set 5 10/08/15, 14:03

    Added steps to reproduce and PageTS to issue for further testing.
  10. Christian Kuhn voted on patch set 5 CR +2 V +2 10/08/15, 16:20

  11. Christian Kuhn merged patch set 5 10/08/15, 16:20