43884[BUGFIX] EXT:form - Wrong attribute handling for attributes in wizard
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Björn Jacob +1
-
Verified V +2
- Christian Kuhn +2
- Björn Jacob +1
Issues 1
Files 3
Review log 11
-
Sebastian Wagner uploaded patch set 1 10/07/15, 11:09
-
Björn Jacob commented on patch set 1 CR -1 10/07/15, 11:12
Ext.ux.form.ValueCheckbox.js:16Please remove comment. -
Sebastian Wagner uploaded patch set 2 10/07/15, 11:48
-
Björn Jacob updated the commit message in patch set 3 10/07/15, 12:10
-
Björn Jacob commented on patch set 3 CR -1 10/07/15, 12:32
Attributes.js:279This one is missing the according configuration. -
Sebastian Wagner uploaded patch set 4 10/07/15, 12:38
-
Björn Jacob updated the commit message in patch set 5 10/07/15, 12:40
-
Björn Jacob commented on patch set 5 CR +1 V +1 10/07/15, 12:44
Awesome. Works for me. The selected attribute is not rendered in the frontend but this is a different issue and does not belong to this patchset. -
Björn Jacob commented on patch set 5 10/08/15, 14:03
Added steps to reproduce and PageTS to issue for further testing. -
Christian Kuhn voted on patch set 5 CR +2 V +2 10/08/15, 16:20
-
Christian Kuhn merged patch set 5 10/08/15, 16:20
Ext.ux.form.ValueCheckbox.js:7