Review main Merged

43894[TASK] EXT:form - remove unused url parameters

Ralf Zimmermann CR +2 V +2 Easy +14 −10 updated 10/08/15, 20:35

Commit message

Set the url parameter "format" only if is set in the configuration
and skip the default extbase arguments.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +2
    • Björn Jacob +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +2
    • Björn Jacob +1

Issues 1

Files 5

Review log 13

  1. Ralf Zimmermann uploaded patch set 1 10/07/15, 16:10

  2. Philipp Gampe voted on patch set 1 CR +1 V +1 10/07/15, 17:15

  3. Björn Jacob voted on patch set 1 CR +1 V +1 10/08/15, 13:39

  4. Christian Kuhn commented on patch set 1 10/08/15, 16:24

    Form.html:29

    Since this is within an argument of an fluid view helper it should use the inline notation.
  5. Christian Kuhn commented on patch set 1 10/08/15, 19:04

    Form.html:29

    same here.

    Form.html:29

    and here.

    Form.html:29

    and here.
  6. Björn Jacob updated the commit message in patch set 2 10/08/15, 19:35

  7. Björn Jacob uploaded patch set 3 10/08/15, 20:14

  8. Björn Jacob commented on patch set 1 10/08/15, 20:22

    Form.html:29 Reply

    Done

    Form.html:29 Reply

    Done

    Form.html:29 Reply

    Done

    Form.html:29 Reply

    Done
  9. Björn Jacob voted on patch set 3 V +1 CR +1 10/08/15, 20:23

  10. Wouter Wolters voted on patch set 3 CR +1 10/08/15, 20:28

  11. Wouter Wolters voted on patch set 3 V +2 CR +2 10/08/15, 20:33

  12. Christian Kuhn voted on patch set 3 CR +2 V +2 10/08/15, 20:35

  13. Christian Kuhn merged patch set 3 10/08/15, 20:35