43905[TASK] Install Tool - Change default action in Standalone context
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Christian Kuhn +1
-
Verified V +2
- Wouter Wolters +2
- Christian Kuhn +1
Issues 1
Files 5
- typo3/sysext/install/Classes/Controller/Action/Tool/About.phprenamed+2 −2
- typo3/sysext/install/Classes/Controller/ToolController.php2+2 −2
- typo3/sysext/install/Resources/Private/Partials/Action/Common/Left.html+5 −0
- typo3/sysext/install/Resources/Private/Templates/Action/Tool/About.htmlrenamed+1 −1
- typo3/sysext/install/Resources/Public/Css/Action/Common/Install.css+1 −1
Review log 7
-
Nicole Hummel uploaded patch set 1 10/08/15, 09:45
-
Nicole Hummel uploaded patch set 2 10/08/15, 13:01
-
Nicole Hummel commented on patch set 2 10/08/15, 13:02
As discussed with Helmut and Benni the default action is changed for all contexts. -
Mathias Brodala commented on patch set 2 10/08/15, 13:12
ToolController.php:171How about "$action = $this->getAction() ?: 'importantActions'"? -
Christian Kuhn commented on patch set 2 CR +1 V +1 10/08/15, 17:14
like.ToolController.php:171Replyminor. i think the above is explicit and easy to read. current solution is fine with me. -
Wouter Wolters voted on patch set 2 V +2 CR +2 10/08/15, 18:31
-
Wouter Wolters merged patch set 2 10/08/15, 18:31