Review main Merged

43905[TASK] Install Tool - Change default action in Standalone context

Nicole Hummel CR +2 V +2 Easy +11 −6 updated 10/08/15, 18:31

Commit message

This patch moves the welcome page to a new action "about" and integrates
it into the navigation. Furthermore the default action is changed
to "importantActions" as this is the most needed action when accessing
the Install Tool.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 5

Review log 7

  1. Nicole Hummel uploaded patch set 1 10/08/15, 09:45

  2. Nicole Hummel uploaded patch set 2 10/08/15, 13:01

  3. Nicole Hummel commented on patch set 2 10/08/15, 13:02

    As discussed with Helmut and Benni the default action is changed for all contexts.
  4. Mathias Brodala commented on patch set 2 10/08/15, 13:12

    ToolController.php:171

    How about "$action = $this->getAction() ?: 'importantActions'"?
  5. Christian Kuhn commented on patch set 2 CR +1 V +1 10/08/15, 17:14

    like.

    ToolController.php:171 Reply

    minor. i think the above is explicit and easy to read. current solution is fine with me.
  6. Wouter Wolters voted on patch set 2 V +2 CR +2 10/08/15, 18:31

  7. Wouter Wolters merged patch set 2 10/08/15, 18:31