Review main Merged

43913[BUGFIX] Encode LiveSearch results properly

Wouter Wolters CR +2 V +2 Easy +3 −3 updated 10/08/15, 20:53

Commit message

Review

  • Code review CR +2
    • Markus Klein +2
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2
    • Markus Klein +2
    • Benni Mack +2

Issues 1

Files 1

Review log 9

  1. Wouter Wolters uploaded patch set 1 10/08/15, 19:23

  2. Markus Klein commented on patch set 1 10/08/15, 19:25

    LiveSearch.php:224

    are you sure? getEditLink sounds like it returns html
  3. Wouter Wolters commented on patch set 1 10/08/15, 19:30

    LiveSearch.php:224 Reply

    it returns a normal link which will be placed in a data attribute. building is done with getModuleUrl
  4. Benni Mack voted on patch set 1 CR +1 V +1 10/08/15, 20:12

  5. Markus Klein voted on patch set 1 CR +1 10/08/15, 20:40

  6. Markus Klein commented on patch set 1 CR +2 V +2 10/08/15, 20:40

    6.2 as well?
  7. Christian Kuhn voted on patch set 1 CR +1 10/08/15, 20:42

  8. Benni Mack commented on patch set 1 CR +2 V +2 10/08/15, 20:53

    nope. was refactored during CMS7 development, does not affect 6.2
  9. Benni Mack merged patch set 1 10/08/15, 20:53