Review main Merged

43917[TASK] Deprecate ExtensionManagementUtility::loadNewTcaColumnsConfigFiles

Nicole Hummel CR +2 V +2 Easy +30 −0 updated 10/08/15, 21:44

Commit message

To enforce developer to move TCA configuration to files in
<extension>/Configuration/TCA the function to include a dynamicConfigFile
in the 'ctrl' section of a table is deprecated now.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
    • Nicole Hummel +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1
    • Nicole Hummel +1

Issues 1

Files 2

Review log 10

  1. Nicole Hummel uploaded patch set 1 10/08/15, 21:10

  2. Christian Kuhn commented on patch set 1 CR -1 10/08/15, 21:14

    this will trigger deprecations in core itself since it calls the method in loadSingleExtTablesFiles and it adds the call to the ext_tables-concat file in createExtTablesCacheEntry
  3. Nicole Hummel uploaded patch set 2 10/08/15, 21:23

  4. Christian Kuhn commented on patch set 2 10/08/15, 21:27

    Deprecation-70514-DynamigConfigFile.rst:8

    has been deprecated and must not be used

    Deprecation-70514-DynamigConfigFile.rst:24

    you must move ... also: hint for compatibiy6 ...
  5. Christian Kuhn uploaded patch set 3 10/08/15, 21:32

  6. Christian Kuhn uploaded patch set 4 10/08/15, 21:36

  7. Christian Kuhn voted on patch set 4 CR +1 V +1 10/08/15, 21:37

  8. Wouter Wolters voted on patch set 4 V +2 CR +2 10/08/15, 21:41

  9. Nicole Hummel voted on patch set 4 CR +1 V +1 10/08/15, 21:41

  10. Wouter Wolters merged patch set 4 10/08/15, 21:44