Review main Merged

43926[BUGFIX] Move option formatToPageTypeMapping

Christian Futterlieb CR +2 V +2 Normal +65 −11 updated 12/09/17, 22:51

Commit message

Move the option formatToPageTypeMapping from
plugin.tx_myextension.settings.view.formatToPageTypeMapping to
plugin.tx_myextension.view.formatToPageTypeMapping

and deprecate the usage of the wrong location.

Review

  • Code review CR +2
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1621

  1. Christian Futterlieb uploaded patch set 1 10/09/15, 09:03

  2. Christian Futterlieb commented on patch set 1 10/09/15, 09:09

    I don't know whether deprecation is needed for this fix or not.. Any opinions on this? Thanks =)
  3. Benni Mack wrote 03/08/16, 06:12

    Patch set 2: Commit message was updated.
  4. Benni Mack commented on patch set 2 03/08/16, 06:13

    nice one. could you also provide a Deprecation RST. while I'm thinking of that... if we're going to deprecate it, it's gonna be master only.
  5. Christian Futterlieb commented on patch set 2 03/08/16, 09:02

    Thats' s why I called it WIP in the first place ;-) I think this needs a decision of the core team members. But I'll surely write the RST when it's going to be needed, ok?
  6. Simon Praetorius commented on patch set 3 08/08/16, 18:04

    Published edit on patch set 2.
  7. TYPO3com voted on patch set 3 V +1 08/08/16, 18:09 Completed build in 05m 04s on Mon, 8 Aug, 08:09 PM Test Summary: 18474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1927

  8. Benni Mack commented on patch set 3 06/15/17, 19:51

    Care to update the patch?
  9. Christian Futterlieb uploaded patch set 4 06/20/17, 09:14

  10. TYPO3com voted on patch set 4 V +1 06/20/17, 09:25 Completed build in 11m 28s on Tue, 20 Jun, 11:25 AM Test Summary: 56498 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12711

  11. Benni Mack uploaded patch set 5 11/30/17, 15:28

  12. Benni Mack voted on patch set 5 CR +1 11/30/17, 15:32

  13. TYPO3com voted on patch set 5 V -1 11/30/17, 15:39 Completed build in 10m 28s on Thu, 30 Nov, 04:39 PM Test Summary: 57044 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17123

  14. Jörg Bösche uploaded patch set 6 12/04/17, 08:06

  15. TYPO3com voted on patch set 6 V -1 12/04/17, 08:06 Completed build in 06s on Mon, 4 Dec, 09:06 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-TL-1877

  16. TYPO3com voted on patch set 6 V +1 12/04/17, 08:16 Completed build in 10m 14s on Mon, 4 Dec, 09:16 AM Test Summary: 57084 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17187

  17. Benni Mack voted on patch set 6 CR +1 12/09/17, 22:48

  18. Susi Moog voted on patch set 6 CR +1 V +1 12/09/17, 22:51

  19. Benni Mack voted on patch set 6 V +1 12/09/17, 22:51

  20. Benni Mack voted on patch set 6 CR +2 V +2 12/09/17, 22:51

  21. Gerrit merged patch set 6 12/09/17, 22:51