Review main Merged

43947[FOLLOWUP][TASK] Use only one instance of iconFactory per class

Andreas Kienast CR +2 V +2 Easy +4 −2 updated 10/09/15, 17:33

Commit message

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Mathias Schreiber +1
    • Wouter Wolters +1
  • Verified V +2
    • Andreas Kienast +2
    • Mathias Schreiber +1
    • Wouter Wolters +1

Issues 1

Files 2

Review log 13

  1. Andreas Kienast uploaded patch set 1 10/09/15, 17:18

  2. Mathias Schreiber commented on patch set 1 CR -2 10/09/15, 17:19

    CGL violation, will push update
  3. Nicole Hummel voted on patch set 1 CR +2 V +2 10/09/15, 17:19

  4. Mathias Schreiber uploaded patch set 2 10/09/15, 17:20

  5. Mathias Schreiber voted on patch set 2 CR +1 V +1 10/09/15, 17:20

  6. Wouter Wolters voted on patch set 2 CR -2 10/09/15, 17:21

  7. Mathias Schreiber uploaded patch set 3 10/09/15, 17:24

  8. Nicole Hummel voted on patch set 3 CR +1 V +1 10/09/15, 17:24

  9. Wouter Wolters uploaded patch set 4 10/09/15, 17:26

  10. Wouter Wolters voted on patch set 4 V +1 CR +1 10/09/15, 17:27

  11. Mathias Schreiber voted on patch set 4 CR +1 V +1 10/09/15, 17:29

  12. Andreas Kienast voted on patch set 4 CR +2 V +2 10/09/15, 17:33

  13. Andreas Kienast merged patch set 4 10/09/15, 17:33