Review main Merged

43951[BUGFIX] FilesReplacePermissionUpdate: Use single quotes in SQL query

Morton Jonuschat CR +2 V +2 Easy +1 −1 updated 10/09/15, 20:37

Commit message

Use single quotes for the like conditions in FilesReplacePermissionUpdate
to tell other DBMS to expect a value and not an identifier.

Using double quotes for values violates the SQL standard.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2
    • Philipp Gampe +1

Issues 1

Files 1

Review log 4

  1. Morton Jonuschat uploaded patch set 1 10/09/15, 20:26

  2. Philipp Gampe voted on patch set 1 CR +1 V +1 10/09/15, 20:31

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 10/09/15, 20:37

  4. Christian Kuhn merged patch set 1 10/09/15, 20:37