43997[TASK] Preserve existing order of dependencies in DependencyOrderingsService
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 4
Review log 5
-
Markus Klein uploaded patch set 1 10/11/15, 22:09
-
Markus Klein updated the commit message in patch set 2 10/11/15, 22:10
-
Christian Kuhn commented on patch set 2 10/13/15, 09:47
hmm, technically, this seems to work. i *hope* the tests cover the use cases, especially for the package list. However, there seems to be a significant performance issue: Open a styleguide record and connect a fal relation at inline_1. This takes factor 10 more time to create with patch applied. Could you have a look at this, Markus? -
Markus Klein commented on patch set 2 CR -1 10/13/15, 11:53
Ok, then this is a no-go. The problem is that the algorithm is O(n^2), still this shouldn't matter that much, even for 40 classes of FormEngine stuff. -
Christian Kuhn abandoned the change 12/08/16, 21:10
ok, abandoned: first because of the negative performance impact, and second, if i give the code some list to order, and it then comes around with something unexpected that makes my code fail, then it just means i didn't specify a dependency that should have been there. other than that we just rely on whatever order the code came up with, which is fine and similar on how php internals work for those cases.