Review main Merged

44016[TASK] Properly encode database input in Typo3DbQueryParser

Helmut Hummel CR +2 V +2 Easy +9 −3 updated 10/17/15, 22:54

Commit message

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Mathias Schreiber +1
    • Morton Jonuschat +1
  • Verified V +2
    • Nicole Hummel +2
    • Mathias Schreiber +1
    • Morton Jonuschat +1

Issues 1

Files 2

Review log 10

  1. Helmut Hummel uploaded patch set 1 10/12/15, 16:35

  2. Mathias Schreiber voted on patch set 1 CR +1 V +1 10/12/15, 17:00

  3. Morton Jonuschat commented on patch set 1 V -1 10/12/15, 17:03

    Unit tests fail
  4. Morton Jonuschat uploaded patch set 2 10/12/15, 17:25

  5. Morton Jonuschat voted on patch set 2 CR +1 V +1 10/12/15, 17:25

  6. Mathias Schreiber voted on patch set 2 CR +1 V +1 10/12/15, 17:31

  7. Nicole Hummel commented on patch set 2 CR -1 10/12/15, 18:42

    on it
  8. Nicole Hummel voted on patch set 2 CR +2 V +2 10/12/15, 18:56

  9. Nicole Hummel merged patch set 2 10/12/15, 18:56

  10. Stephan Großberndt commented on patch set 3 10/17/15, 22:54

    Typo3DbQueryParserTest.php:16

    missing newline