44025[TASK] Enable EM offline mode when using composer
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Stephan Großberndt +1
- Daniel Maier +1
- Michael Oehlhof +1
-
Verified V +2
- Helmut Hummel +2
- Daniel Maier +1
- Michael Oehlhof +1
Issues 1
Files 7
- typo3/sysext/extensionmanager/Classes/Controller/ListController.php+3 −0
- typo3/sysext/extensionmanager/Classes/Controller/UploadExtensionFileController.php+13 −0
- typo3/sysext/extensionmanager/Classes/Utility/Connection/TerUtility.php+5 −1
- typo3/sysext/extensionmanager/Resources/Private/Language/locallang.xlf+1 −1
- typo3/sysext/extensionmanager/Resources/Private/Layouts/Main.html+11 −7
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/Index.html+9 −5
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/Ter.html+9 −5
Review log 18
-
Nicole Hummel uploaded patch set 1 10/13/15, 08:52
-
Daniel Goerz commented on patch set 1 CR +1 10/13/15, 18:14
Looks good -
Stephan Großberndt updated the commit message in patch set 2 10/13/15, 20:11
-
Stephan Großberndt voted on patch set 2 CR +1 10/13/15, 20:14
-
Daniel Goerz voted on patch set 2 CR +1 10/13/15, 20:21
-
Frans Saris commented on patch set 2 10/13/15, 20:33
"the extension installation is prevented" I expect that this is not 100% correct. or is there a new preferred way to install extensions when in composer modemode -
Daniel Maier commented on patch set 2 V +1 10/13/15, 20:49
Just one point: Should we have some kind of marketing text for distributions when the extension manager when composer mode is activated? As the menu item "Get Preconfigured Distributions" is disabled in that case, people who are new to TYPO3 will not know that there are distrubtions they could use to start... Perhaps a short info text telling how to get distributions in composer mode would help here... -
Frans Saris commented on patch set 2 CR -1 10/14/15, 11:15
"If the composer mode is activated, the Extension Manager has to be set to offline mode so downloading and installing extensions from TER is prevented." Something like this? -
Daniel Goerz commented on patch set 2 10/14/15, 11:20
Reply
Installation is not prevented in any case. Just downloading and uploading. -
Stephan Großberndt updated the commit message in patch set 3 10/14/15, 11:36
-
Stephan Großberndt voted on patch set 3 CR +1 10/14/15, 11:37
-
Michael Oehlhof commented on patch set 3 CR +1 V +1 10/14/15, 12:02
Verified only with a composer installation. -
Daniel Maier voted on patch set 3 CR +1 V +1 10/14/15, 12:10
-
Helmut Hummel commented on patch set 3 CR -1 10/14/15, 12:19
will review now -
Helmut Hummel voted on patch set 3 CR +2 V +2 10/14/15, 12:29
-
Helmut Hummel merged patch set 3 10/14/15, 12:29
-
Josef Glatz voted on patch set 2 V +1 01/09/19, 20:56
-
Josef Glatz voted on patch set 2 CR +1 01/09/19, 20:56