Review main Merged

44026[BUGFIX] Skip unit test depending on Composer mode

Nicole Hummel CR +2 V +2 Easy +16 −0 updated 10/22/15, 08:54

Commit message

The test isCoreUpdateEnabledReturnsTrueForEnvironmentVariableNotSet in
\TYPO3\CMS\Install\Service\CoreUpdateServiceTest depends on the
TYPO3_COMPOSER_MODE environment variable. This test should be skipped
if unit tests are running in Composer mode. An additional test for the
Composer mode is added to ensure the updater returns false.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
    • Morton Jonuschat +1
  • Verified V +2
    • Wouter Wolters +2
    • Morton Jonuschat +1

Issues 1

Files 1

Review log 6

  1. Nicole Hummel uploaded patch set 1 10/13/15, 09:24

  2. Morton Jonuschat voted on patch set 1 CR +1 V +1 10/16/15, 16:06

  3. Stefan Neufeind commented on patch set 1 10/17/15, 09:34

    Does phpunit backup/restore environment-variables? Or should we unset it in case we use putenv() to set composer-mode?
  4. Stefan Neufeind voted on patch set 1 CR +1 10/18/15, 15:57

  5. Wouter Wolters commented on patch set 1 V +2 CR +2 10/22/15, 08:54

    We do not reset other env variables either so if that should be changed (which is AFAICS not needed) later.
  6. Wouter Wolters merged patch set 1 10/22/15, 08:54