44034[TASK] EXT:form - Set proper default values in form wizard
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Morton Jonuschat +1
-
Verified V +2
- Wouter Wolters +2
- Morton Jonuschat +1
Issues 1
Files 7
- typo3/sysext/form/Classes/Domain/Factory/JsonToTypoScript.php1+1 −1
- typo3/sysext/form/Configuration/PageTS/modWizards.ts+94 −21
- typo3/sysext/form/Configuration/TypoScript/Elements/Textline.ts+0 −9
- typo3/sysext/form/Resources/Public/JavaScript/Wizard/Elements/Basic/Button.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/Wizard/Elements/Basic/Form.js+4 −2
- typo3/sysext/form/Resources/Public/JavaScript/Wizard/Elements/Predefined/Email.js+2 −1
- typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Attributes.js+1 −11
Review log 8
-
Björn Jacob uploaded patch set 1 10/13/15, 21:01
-
Andreas Kienast commented on patch set 1 10/16/15, 07:47
-
Björn Jacob commented on patch set 1 10/16/15, 11:23
Either !empty or !== would cause problems since they would not allow 0 as valid value. The form wizard does not cast the values to string. The 0 is kept as int. Setting 0 is a valid value. For example imagine having a checkbox which has an attribute "value" set to 0. So !empty and !== ar no solution. See https://secure.php.net/manual/de/types.comparisons.php. So maybe we have to think about casting the values. -
Andreas Kienast voted on patch set 1 CR +1 10/16/15, 12:08
-
Morton Jonuschat uploaded patch set 2 10/16/15, 15:21
-
Morton Jonuschat voted on patch set 2 CR +1 V +1 10/16/15, 15:22
-
Wouter Wolters voted on patch set 2 V +2 CR +2 10/16/15, 18:13
-
Wouter Wolters merged patch set 2 10/16/15, 18:13
JsonToTypoScript.php:309