Review main Merged

44034[TASK] EXT:form - Set proper default values in form wizard

Björn Jacob CR +2 V +2 Normal +103 −46 updated 10/16/15, 18:13

Commit message

This patch sets proper default values for all elements in the form
wizard. The available elements and fields have been sorted by necessity,
i.e. most often used elements have been moved to the top.

The type of the TEXTLINE element can now be modified. That way the editor
can create HTML5 input types. The avaible input types within the wizard
have been streamlined to not show duplicate elements like checkbox or
radio (which are elements on their own). The right side of the wizard
has been optimized to not validate elements according to their HTML5
attributes. Last but not least the predefined email element is now of
type email.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Morton Jonuschat +1
  • Verified V +2
    • Wouter Wolters +2
    • Morton Jonuschat +1

Issues 1

Files 7

Review log 8

  1. Björn Jacob uploaded patch set 1 10/13/15, 21:01

  2. Andreas Kienast commented on patch set 1 10/16/15, 07:47

    JsonToTypoScript.php:309

    Please check either with !== or empty(), depending on what type $value is.
  3. Björn Jacob commented on patch set 1 10/16/15, 11:23

    Either !empty or !== would cause problems since they would not allow 0 as valid value. The form wizard does not cast the values to string. The 0 is kept as int. Setting 0 is a valid value. For example imagine having a checkbox which has an attribute "value" set to 0. So !empty and !== ar no solution. See https://secure.php.net/manual/de/types.comparisons.php. So maybe we have to think about casting the values.
  4. Andreas Kienast voted on patch set 1 CR +1 10/16/15, 12:08

  5. Morton Jonuschat uploaded patch set 2 10/16/15, 15:21

  6. Morton Jonuschat voted on patch set 2 CR +1 V +1 10/16/15, 15:22

  7. Wouter Wolters voted on patch set 2 V +2 CR +2 10/16/15, 18:13

  8. Wouter Wolters merged patch set 2 10/16/15, 18:13