Review main Abandoned

4404[FEATURE] Added figure image rendering mode to css-styled-content.

Martin Ficzel CR 0 V 0 Easy +12 −2 updated 06/03/13, 20:49

Commit message

A new rendermode figure is introduced that enables the html5 figure
element for typo3-images.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 7

  1. Patrick Broens commented on patch set 1 1 comment 10/31/11, 07:36

    Do not submit First of all, this patch is targeted for version 4.6 which is already in feature freeze. Second of all, for 4.7, we are already in the process to rewrite parts of css_styled_content with HTML5 output and proper W3C validation for all doctypes. This patch would collide with our changes. Please have a look at http://news.typo3.org/news/article/typo3-receives-german-governmental-funding-for-accessibility-and-usability-project/ for more information about the project and http://forge.typo3.org/projects/typo3v4-accessibility for the Accessibility project which is targeted for 4.7. If you want to contribute, please have a look at this specific branch.
  2. Björn Pedersen commented on patch set 1 10/31/11, 07:36

    Looks good to me, but someone else must approve
  3. Markus Klein commented on patch set 1 10/31/11, 07:36

    No score Hi Martin, As Patrick said, please contribute to the new project and abandon this change request. Thank you.
    4.6 is already in feature freeze. Please change to 4.7 Thanks
  4. Markus Klein commented on patch set 1 1 comment 10/31/11, 07:36

    I would prefer that you didn't submit this
  5. Georg Ringer commented on patch set 1 10/31/11, 07:36

    Looks good to me, but someone else must approve

    setup.txt:717

    whitespaces
  6. Mr. Jenkins commented on patch set 1 10/31/11, 07:36

  7. Martin Ficzel commented on patch set 1 10/31/11, 07:36

    Abandoned This is rejected an so it makes no sense to keep the issue open. Lets see what the BLE project will bring.