Review main Merged

44042[BUGFIX] Drop usage of iconFile if typeicon_classes is used in TCA

Georg Ringer CR +2 V +2 Easy +1 −30 updated 01/09/19, 20:56

Commit message

If typeicon_classes is used, the iconFile is not required.

Furthermore using an icon identifier instead of a file in iconFile
triggers an entry in the deprecation log and a wrong TCA migration.

The identifiers are not used anywhere else and can be removed in the
IconRegistry.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Frank Nägler +1
  • Verified V +2
    • Anja Leichsenring +2
    • Frank Nägler +1

Issues 1

Files 5

Review log 5

  1. Georg Ringer uploaded patch set 1 10/14/15, 08:28

  2. Frank Nägler commented on patch set 1 CR +1 10/14/15, 08:43

    testing later this evening
  3. Frank Nägler voted on patch set 1 V +1 10/14/15, 17:09

  4. Anja Leichsenring voted on patch set 1 CR +2 V +2 10/15/15, 06:24

  5. Anja Leichsenring merged patch set 1 10/15/15, 06:24