Review TYPO3_6-2 Merged

44043[BUGFIX] Position NULL-Checkbox left of TCA input

Stephan Großberndt CR +2 V +2 Easy +1 −1 updated 11/24/15, 09:42

Commit message

Positioning of the checkbox to nullify an TCA field is handled by the
FormEngine-Rewrite on master but not on 6.2. This patch positions the
NULL-Checkbox left of TCA input instead of to the far right.

Review

  • Code review CR +2
    • Mathias Schreiber +2
    • Christian Kuhn +1
  • Verified V +2
    • Mathias Schreiber +2
    • Stefan Neufeind +1
    • Christian Kuhn +1

Issues 1

Files 1

Review log 10

  1. Stephan Großberndt uploaded patch set 1 10/14/15, 08:54

  2. Andreas Kienast voted on patch set 1 CR +1 10/14/15, 09:23

  3. Stephan Großberndt uploaded patch set 2 10/14/15, 17:29

  4. Stefan Neufeind commented on patch set 2 11/15/15, 11:30

    ping?
  5. Stefan Neufeind commented on patch set 2 V +1 11/15/15, 13:31

    Works as advertised. I see the benefit of not having it "on the far right". But I'm unsure if having it *left* of the field in question is really an option. Having it directly on the right of the field would, on the other hand, collide with the wizard-icon etc. In current master the checkbox is above the field, in it's own row and without any description ... not optimal as well imho. Somebody like RM or PO imho definitively needs to sign this off first before we can have it.
  6. Stefan Neufeind commented on patch set 2 11/15/15, 13:34

    I've added two screenshots for 6.2 with this patch as well as 7LTS in the forge-issue.
  7. Stephan Großberndt commented on patch set 2 11/15/15, 13:35

    I added this CSS inside an extension of mine since editors just did not find those checkboxes. It's definitely a change to the better to have the checkbox next to the field. Exactly because of the wizards I think having the NULL checkbox to the left of the input is the correct place.
  8. Christian Kuhn voted on patch set 2 CR +1 V +1 11/24/15, 09:37

  9. Mathias Schreiber commented on patch set 2 CR +2 V +2 11/24/15, 09:42

    not exactly what I'd call a "Priority Bugfix".
  10. Gerrit merged patch set 2 11/24/15, 09:42