44065[TASK] Add new property displayName to ShortcutButton
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Daniel Goerz +1
-
Verified V +2
- Stefan Neufeind +2
- Daniel Goerz +1
Issues 1
Files 4
- typo3/sysext/backend/Classes/Backend/ToolbarItems/ShortcutToolbarItem.php+5 −0
- typo3/sysext/backend/Classes/Template/Components/Buttons/Action/ShortcutButton.php6+32 −5
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php2+8 −4
- typo3/sysext/backend/Resources/Public/JavaScript/Toolbar/ShortcutMenu.js+3 −2
Review log 31
Show 6 earlier messages
-
Michael Oehlhof uploaded patch set 1 10/14/15, 19:54
-
Michael Oehlhof updated the commit message in patch set 2 10/14/15, 20:07
-
Michael Oehlhof updated the commit message in patch set 3 10/14/15, 20:23
-
Helmut Hummel commented on patch set 3 CR -1 10/14/15, 20:33
Ihmo this should be split into several commits (enhance the API, use the API)ShortcutButton.php:228why using the getter here?DocumentTemplate.php:658I wouldn't change the old API -
Michael Oehlhof commented on patch set 3 10/14/15, 21:27
I will split it and make a new task for the API enhancement and this bugfix then relates on it.ShortcutButton.php:228ReplyDon't know. I change it to use the local variable.DocumentTemplate.php:658ReplyThe ShortcutButton uses the old API. ShortcutButton.php 221-222 -
Michael Oehlhof uploaded patch set 4 10/18/15, 21:52
-
Michael Oehlhof updated the commit message in patch set 5 10/18/15, 21:53
-
Stefan Neufeind voted on patch set 5 CR +1 V +1 10/21/15, 21:19
-
Wouter Wolters commented on patch set 5 CR -1 10/22/15, 08:21
ShortcutButton.php:221We should use the ModuleTemplate here. We want to get rid of DocumentTemplate.ShortcutButton.php:228use $this->displayName hereDocumentTemplate.php:658do not change this here. -
Michael Oehlhof commented on patch set 5 10/22/15, 08:47
DocumentTemplate.php:658ReplyWe must change it here because in ShortcutButton.php line 221 the DocumentTemplate is used. -
Michael Oehlhof commented on patch set 5 10/22/15, 08:50
ShortcutButton.php:221ReplyThat was not in the scope of this patch, but it make sense. Will change it this evening. -
Michael Oehlhof uploaded patch set 6 10/22/15, 16:53
-
Daniel Goerz commented on patch set 6 V -1 10/23/15, 08:08
The Shortcut-Icons are no buttons anymore.ModuleTemplate.php:546The @param annotation for $displayName is missing -
Daniel Goerz commented on patch set 6 V 0 10/23/15, 08:11
Actually not the fault of this patch. -
Daniel Goerz commented on patch set 6 V -1 10/23/15, 08:16
Turns out I am not able to properly use git and that this patch indeed removes the button classes from the shortcut icons. -
Michael Oehlhof commented on patch set 6 10/23/15, 08:30
Ah, OK. That is the result of changing from DocumentTemplate to ModuleTeemplate as mentioned by Wouter. I have to investigate later this day. -
Daniel Goerz commented on patch set 6 10/23/15, 08:32
It also moves the shortcut icon to the rightmost position. -
Michael Oehlhof commented on patch set 6 10/23/15, 08:46
I will also change the position, thanks for having a look. -
Michael Oehlhof uploaded patch set 7 10/23/15, 10:31
-
Daniel Goerz commented on patch set 7 CR -1 10/23/15, 10:59
ShortcutButton.php:227$this->displayNameModuleTemplate.php:546The @param annotation for $displayName and $classes are missingPageLayoutView.php:1150Is this supposed to be here? -
Michael Oehlhof uploaded patch set 8 10/23/15, 11:38
-
Frank Nägler voted on patch set 8 CR +1 10/23/15, 13:49
-
Frank Nägler voted on patch set 8 V +1 10/23/15, 13:59
-
Stefan Neufeind commented on patch set 8 CR +1 10/23/15, 14:07
I tried it with https://review.typo3.org/44144 but that patch over there doesn't seem to work for me currently. By reading this patch here seems okay though. @Frank: With what module did you test? -
Daniel Goerz commented on patch set 8 CR -1 10/23/15, 14:16
If you go to a bookmarked page again the 2active star is shown, but that markup is broken. Additionally previosly created shortcuts are no longer recognized as "active" and can be created again. -
Michael Oehlhof uploaded patch set 9 10/24/15, 02:09
-
Daniel Goerz commented on patch set 9 CR +1 V +1 10/25/15, 11:27
Just another thing (but not for this patch as it already does more than it states): The Shortcut-List is not scrollable. So your maximum of usable shprtcuts is determined by your screen resolution. -
Stefan Neufeind commented on patch set 9 10/25/15, 11:43
@Daniel: I've filed a separate issue for that, so we don't forget. https://forge.typo3.org/issues/71004 -
Daniel Goerz commented on patch set 9 10/25/15, 11:46
me too :) -
Stefan Neufeind commented on patch set 9 CR +2 V +2 10/25/15, 11:53
Tested with https://review.typo3.org/44144. The new functionality works as advertised. And if not set the title is as before. -
Stefan Neufeind merged patch set 9 10/25/15, 11:53