44066[BUGFIX] BE-Module "Access": Fixed "weird" styling and behavior
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Michael Oehlhof +1
-
Verified V +2
- Markus Klein +2
- Michael Oehlhof +1
Issues 1
Files 2
Review log 31
Show 6 earlier messages
-
Michael Oehlhof uploaded patch set 1 10/14/15, 20:54
-
Helmut Hummel commented on patch set 1 10/14/15, 20:57
please change the commit message to something meaningful. e.g. mention what this commit fixes -
Michael Oehlhof updated the commit message in patch set 2 10/14/15, 21:01
-
Michael Oehlhof uploaded patch set 3 10/14/15, 21:12
-
Marcus Schwemer voted on patch set 3 V +1 10/14/15, 21:15
-
Andreas Kienast commented on patch set 3 CR -1 10/14/15, 21:25
on itPermissionController.php:166We should hide this button on uid 0
-
Andreas Kienast uploaded patch set 4 10/14/15, 21:28
-
Andreas Kienast voted on patch set 4 CR +1 V +1 10/14/15, 21:28
-
Michael Oehlhof uploaded patch set 5 10/14/15, 21:36
-
Andreas Kienast voted on patch set 5 CR +1 V +1 10/14/15, 21:38
-
Marcus Schwemer voted on patch set 5 CR +1 10/15/15, 13:26
-
Marcus Schwemer voted on patch set 5 V +1 10/15/15, 13:27
-
Daniel Goerz voted on patch set 5 CR +1 V +1 10/15/15, 17:14
-
Markus Klein updated the commit message in patch set 6 10/15/15, 18:10
-
Markus Klein commented on patch set 6 10/15/15, 18:14
When we talk of styling here. The avatar is displayed behind the username, that looks strange too. can you fix that? -
Michael Oehlhof commented on patch set 6 10/15/15, 19:19
With styling Markus meant the broken layout. The avatar is like in 7.5. What is missing in this patch is the View button. I will add the view button in the next patch set. -
Michael Oehlhof commented on patch set 6 10/15/15, 19:22
The view button is not missing, was not on page when checking with 7.5 -
Michael Oehlhof commented on patch set 6 CR +1 V +1 10/15/15, 19:24
Can we move the avatar thingy to an own item? This patch should only repair the broken layout. -
Daniel Goerz voted on patch set 6 CR +1 V +1 10/15/15, 19:27
-
Marcus Schwemer commented on patch set 6 CR +1 V +1 10/15/15, 19:28
+1 ... wrote that on slack too, since there is another issue with the styling -
Markus Klein commented on patch set 6 10/15/15, 19:56
PermissionController.php:167$this->view->getModuleTemplate()->getIconFactory() should be preferred -
Marcus Schwemer uploaded patch set 7 10/15/15, 20:41
-
Marcus Schwemer commented on patch set 7 10/15/15, 20:46
takes Markus' suggestion into account -
Markus Klein commented on patch set 7 CR +1 V +1 10/15/15, 20:51
thanks for the update -
Markus Klein voted on patch set 7 V 0 CR 0 10/15/15, 20:51
-
Marcus Schwemer uploaded patch set 8 10/15/15, 20:58
-
Michael Oehlhof commented on patch set 8 CR -1 10/15/15, 21:03
IconFactory can be removed from the use statements. Instead of variable $iconFactory the getIconFactory call can be made in line 172. -
Markus Klein uploaded patch set 9 10/15/15, 21:06
-
Michael Oehlhof voted on patch set 9 CR +1 V +1 10/15/15, 21:07
-
Markus Klein voted on patch set 9 CR +2 V +2 10/15/15, 21:08
-
Markus Klein merged patch set 9 10/15/15, 21:08