Review main Merged

44066[BUGFIX] BE-Module "Access": Fixed "weird" styling and behavior

Michael Oehlhof CR +2 V +2 Normal +78 −1 updated 10/15/15, 21:08

Commit message

During implementation of the ModuleTemplate API for ext:beuser,
the changes for the access module were only half done.

Review

  • Code review CR +2
    • Markus Klein +2
    • Michael Oehlhof +1
  • Verified V +2
    • Markus Klein +2
    • Michael Oehlhof +1

Issues 1

Files 2

Review log 31

Show 6 earlier messages
  1. Michael Oehlhof uploaded patch set 1 10/14/15, 20:54

  2. Helmut Hummel commented on patch set 1 10/14/15, 20:57

    please change the commit message to something meaningful. e.g. mention what this commit fixes
  3. Michael Oehlhof updated the commit message in patch set 2 10/14/15, 21:01

  4. Michael Oehlhof uploaded patch set 3 10/14/15, 21:12

  5. Marcus Schwemer voted on patch set 3 V +1 10/14/15, 21:15

  6. Andreas Kienast commented on patch set 3 CR -1 10/14/15, 21:25

    on it

    PermissionController.php:166

    We should hide this button on uid 0
  1. Andreas Kienast uploaded patch set 4 10/14/15, 21:28

  2. Andreas Kienast voted on patch set 4 CR +1 V +1 10/14/15, 21:28

  3. Michael Oehlhof uploaded patch set 5 10/14/15, 21:36

  4. Andreas Kienast voted on patch set 5 CR +1 V +1 10/14/15, 21:38

  5. Marcus Schwemer voted on patch set 5 CR +1 10/15/15, 13:26

  6. Marcus Schwemer voted on patch set 5 V +1 10/15/15, 13:27

  7. Daniel Goerz voted on patch set 5 CR +1 V +1 10/15/15, 17:14

  8. Markus Klein updated the commit message in patch set 6 10/15/15, 18:10

  9. Markus Klein commented on patch set 6 10/15/15, 18:14

    When we talk of styling here. The avatar is displayed behind the username, that looks strange too. can you fix that?
  10. Michael Oehlhof commented on patch set 6 10/15/15, 19:19

    With styling Markus meant the broken layout. The avatar is like in 7.5. What is missing in this patch is the View button. I will add the view button in the next patch set.
  11. Michael Oehlhof commented on patch set 6 10/15/15, 19:22

    The view button is not missing, was not on page when checking with 7.5
  12. Michael Oehlhof commented on patch set 6 CR +1 V +1 10/15/15, 19:24

    Can we move the avatar thingy to an own item? This patch should only repair the broken layout.
  13. Daniel Goerz voted on patch set 6 CR +1 V +1 10/15/15, 19:27

  14. Marcus Schwemer commented on patch set 6 CR +1 V +1 10/15/15, 19:28

    +1 ... wrote that on slack too, since there is another issue with the styling
  15. Markus Klein commented on patch set 6 10/15/15, 19:56

    PermissionController.php:167

    $this->view->getModuleTemplate()->getIconFactory() should be preferred
  16. Marcus Schwemer uploaded patch set 7 10/15/15, 20:41

  17. Marcus Schwemer commented on patch set 7 10/15/15, 20:46

    takes Markus' suggestion into account
  18. Markus Klein commented on patch set 7 CR +1 V +1 10/15/15, 20:51

    thanks for the update
  19. Markus Klein voted on patch set 7 V 0 CR 0 10/15/15, 20:51

  20. Marcus Schwemer uploaded patch set 8 10/15/15, 20:58

  21. Michael Oehlhof commented on patch set 8 CR -1 10/15/15, 21:03

    IconFactory can be removed from the use statements. Instead of variable $iconFactory the getIconFactory call can be made in line 172.
  22. Markus Klein uploaded patch set 9 10/15/15, 21:06

  23. Michael Oehlhof voted on patch set 9 CR +1 V +1 10/15/15, 21:07

  24. Markus Klein voted on patch set 9 CR +2 V +2 10/15/15, 21:08

  25. Markus Klein merged patch set 9 10/15/15, 21:08