Review main Merged

44070[BUGFIX] Fix fatal error in PermissionController

Michael Oehlhof CR +2 V +2 Easy +16 −13 updated 10/15/15, 21:37

Commit message

Make sure we deal with the correct view class before accessing
any members of it.

Review

  • Code review CR +2
    • Markus Klein +2
    • Marcus Schwemer +1
    • Michael Oehlhof +1
  • Verified V +2
    • Markus Klein +2
    • Marcus Schwemer +1
    • Michael Oehlhof +1

Issues 1

Files 1

Review log 14

  1. Michael Oehlhof uploaded patch set 1 10/14/15, 22:13

  2. Andreas Kienast commented on patch set 1 10/14/15, 22:34

  3. Michael Oehlhof commented on patch set 1 CR -1 10/15/15, 05:27

    It works but must be solved in a better way. Will be done after 44066 is merged.
  4. Michael Oehlhof uploaded patch set 2 10/15/15, 21:12

  5. Marcus Schwemer commented on patch set 2 V -1 10/15/15, 21:24

    I get an error 500 in the initial call of the module
  6. Markus Klein uploaded patch set 3 10/15/15, 21:32

  7. Markus Klein updated the commit message in patch set 4 10/15/15, 21:33

  8. Michael Oehlhof voted on patch set 3 CR +1 V +1 10/15/15, 21:34

  9. Markus Klein voted on patch set 4 CR +1 V +1 10/15/15, 21:34

  10. Michael Oehlhof voted on patch set 4 CR +1 V +1 10/15/15, 21:34

  11. Marcus Schwemer voted on patch set 3 V +1 10/15/15, 21:35

  12. Marcus Schwemer voted on patch set 4 CR +1 V +1 10/15/15, 21:37

  13. Markus Klein voted on patch set 4 CR +2 V +2 10/15/15, 21:37

  14. Markus Klein merged patch set 4 10/15/15, 21:37