44077[BUGFIX] Fix fatal error in PageLayoutController
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Daniel Goerz +1
- Marcus Schwemer +1
-
Verified V +2
- Markus Klein +2
- Daniel Goerz +1
- Marcus Schwemer +1
Issues 1
Files 1
Review log 14
-
Georg Ringer uploaded patch set 1 10/15/15, 10:45
-
Andreas Allacher voted on patch set 1 CR +1 V +1 10/15/15, 12:47
-
Andreas Kienast commented on patch set 1 10/15/15, 12:51
D other locations need some love, too? For example the EditDocumentController has a similar line, but I'm unsure if such check is required there. -
Andreas Allacher commented on patch set 1 10/15/15, 16:51
@Andreas Fernandez: Will test some other locations tomorroow but probably the will also need a similar change :) -
Daniel Goerz voted on patch set 1 CR +1 V +1 10/15/15, 17:17
-
Markus Klein commented on patch set 1 10/15/15, 18:09
We passed an empty array in a different patch in case no pageinfo is there. What should it be like? -
Markus Klein uploaded patch set 2 10/15/15, 18:23
-
Markus Klein uploaded patch set 3 10/15/15, 18:26
-
Markus Klein updated the commit message in patch set 4 10/15/15, 18:27
-
Markus Klein voted on patch set 4 CR +1 V +1 10/15/15, 18:28
-
Daniel Goerz voted on patch set 4 CR +1 V +1 10/15/15, 19:03
-
Marcus Schwemer voted on patch set 4 CR +1 V +1 10/15/15, 20:04
-
Markus Klein voted on patch set 4 CR +2 V +2 10/15/15, 20:33
-
Markus Klein merged patch set 4 10/15/15, 20:33