44078[BUGFIX] SelectTreeElement modify expandstate after tree was loaded
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Morton Jonuschat +1
- Michael Oehlhof +1
-
Verified V +2
- Christian Kuhn +2
- Morton Jonuschat +1
Issues 1
Files 1
Review log 11
-
Andreas Allacher uploaded patch set 1 10/15/15, 11:26
-
Andreas Allacher commented on patch set 1 CR -1 10/15/15, 16:53
I noticed that during initialization there are still a lot of requests though far less than previously. I need to check if there is an even better way to do this. -
Mathias Schreiber updated the commit message in patch set 2 10/15/15, 17:11
-
Daniel Goerz commented on patch set 2 CR -1 10/15/15, 17:19
Applied the -1 of Andreas again -
Andreas Allacher uploaded patch set 3 10/16/15, 11:32
-
Andreas Allacher commented on patch set 3 10/16/15, 11:34
This works. Now it only modifies the state after rendering the tree. Apparantly during rendering nodes are expanded multiple times and before and after they are loaded. -
Andreas Allacher updated the commit message in patch set 4 10/16/15, 11:34
-
Morton Jonuschat commented on patch set 4 CR +1 V +1 10/16/15, 12:02
Verified using tests & EXT:styleguide -
Michael Oehlhof voted on patch set 4 CR +1 10/16/15, 22:53
-
Christian Kuhn voted on patch set 4 V +2 CR +2 10/17/15, 13:05
-
Christian Kuhn merged patch set 4 10/17/15, 13:05