Review main Merged

44096[BUGFIX] Allow to show all tables of a given pid in List Record Tasks

Mathias Schreiber CR +2 V +2 Easy +9 −11 updated 10/16/15, 12:28

Commit message

The setting "Only show tables" in the List Records task is no mandatory
setting, but the application logic treated it as if it was.
Now you can show all tables on a given pid again.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Daniel Goerz +1
    • Wouter Wolters +1
    • Morton Jonuschat +1
  • Verified V +2
    • Oliver Hader +2
    • Daniel Goerz +1
    • Morton Jonuschat +1

Issues 1

Files 2

Review log 9

  1. Mathias Schreiber uploaded patch set 1 10/16/15, 08:27

  2. Wouter Wolters voted on patch set 1 CR +1 10/16/15, 08:35

  3. Morton Jonuschat voted on patch set 1 CR +1 V +1 10/16/15, 08:36

  4. Oliver Hader voted on patch set 1 CR +1 10/16/15, 08:37

  5. Daniel Goerz voted on patch set 1 CR +1 V +1 10/16/15, 08:40

  6. Oliver Hader commented on patch set 1 10/16/15, 08:42

    ActionTask.php:799

    Can it be ensured, that the table name is always set in the sys_action record?
  7. Mathias Schreiber commented on patch set 1 10/16/15, 08:46

    ActionTask.php:799 Reply

    sure, we could refactor this, but imagine having an extension which has like 3 tables (seminars, survey, whatever). You'd need several tasks for that. Pretty inconvenient.
  8. Oliver Hader commented on patch set 1 CR +2 V +2 10/16/15, 12:28

    Has enough votes

    ActionTask.php:799 Reply

    Was not about refactoring but more, whether this might have side effects on removing the table name check... Anyway this is was this patch is all about and RecordList handles that...
  9. Oliver Hader merged patch set 1 10/16/15, 12:28