Review main Abandoned

44113[BUGFIX] Disallow integers in pages.alias

Mathias Schreiber CR 0 V 0 Easy +8 −1 updated 04/08/16, 14:56

Commit message

Using a pure integer in pages.alias makes no sense, but was not captured
up until now.
Using eval="notint" allows to do so.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 10

  1. Mathias Schreiber uploaded patch set 1 10/16/15, 15:13

  2. Frank Nägler voted on patch set 1 CR +1 10/16/15, 15:23

  3. Frank Nägler commented on patch set 1 V +1 10/16/15, 15:31

    Code tested in CMS and with this testscript: http://jsfiddle.net/43s305dd/1/
  4. Tymoteusz Motylewski updated the commit message in patch set 2 10/16/15, 15:37

  5. Tymoteusz Motylewski commented on patch set 2 10/16/15, 15:37

    fixed typo in the commit message
  6. Morton Jonuschat commented on patch set 2 CR -1 V -1 10/16/15, 15:45

    Fails with leading zeros

    FormEngineValidation.js:437

    The radix (10) should be provided, otherwise parseInt tries to determine hex, octal and the like on its own.
  7. Oliver Hader commented on patch set 2 CR -1 10/16/15, 15:45

    The notint evaluation is missing in the DataHandler
  8. Frank Nägler commented on patch set 2 10/26/15, 17:12

    regarding the concerns of Morton, I created a new JSFiddle with a better test and some more test cases: http://jsfiddle.net/43s305dd/3/
  9. Alexander Opitz commented on patch set 2 10/30/15, 10:36

    FormEngineValidation.js:437 Reply

    If the value is "123 " then this test will fail. Also "notint" seams to mean that the string isn't same as a integer number but not that there is no number inside string.
  10. Frank Nägler abandoned the change 04/08/16, 14:56

    after a talk to Mattes, we abandon this patch for now