44113[BUGFIX] Disallow integers in pages.alias
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 10
-
Mathias Schreiber uploaded patch set 1 10/16/15, 15:13
-
Frank Nägler voted on patch set 1 CR +1 10/16/15, 15:23
-
Frank Nägler commented on patch set 1 V +1 10/16/15, 15:31
Code tested in CMS and with this testscript: http://jsfiddle.net/43s305dd/1/ -
Tymoteusz Motylewski updated the commit message in patch set 2 10/16/15, 15:37
-
Tymoteusz Motylewski commented on patch set 2 10/16/15, 15:37
fixed typo in the commit message -
Morton Jonuschat commented on patch set 2 CR -1 V -1 10/16/15, 15:45
Fails with leading zerosFormEngineValidation.js:437The radix (10) should be provided, otherwise parseInt tries to determine hex, octal and the like on its own. -
Oliver Hader commented on patch set 2 CR -1 10/16/15, 15:45
The notint evaluation is missing in the DataHandler -
Frank Nägler commented on patch set 2 10/26/15, 17:12
regarding the concerns of Morton, I created a new JSFiddle with a better test and some more test cases: http://jsfiddle.net/43s305dd/3/ -
Alexander Opitz commented on patch set 2 10/30/15, 10:36
FormEngineValidation.js:437ReplyIf the value is "123 " then this test will fail. Also "notint" seams to mean that the string isn't same as a integer number but not that there is no number inside string. -
Frank Nägler abandoned the change 04/08/16, 14:56
after a talk to Mattes, we abandon this patch for now