Review TYPO3_6-2 Merged

44120[BUGFIX] Possible silent fatal error with legacy extensions

Xavier Perseguers CR +2 V +2 Easy +1 −1 updated 10/19/15, 08:32

Commit message

The use of the '@' symbol while including an extension update script
may result into a PHP fatal error being totally muted which in turn
results into a blank screen.

In TYPO3 6.2, this happens when a legacy extension is trying to manually
include class t3lib_SCbase in its update script:

    require_once(PATH_t3lib . 'class.t3lib_scbase.php');

Having a white screen and no log entry makes it really hard to
understand where the error comes from. The Install Tool does not help
either since the check for broken extensions only tries to include
ext_tables.php and ext_localconf.php.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Stefan Neufeind +1
  • Verified V +2
    • Xavier Perseguers +2

Issues 1

Files 1

Review log 6

  1. Xavier Perseguers uploaded patch set 1 10/17/15, 07:06

  2. Xavier Perseguers updated the commit message in patch set 2 10/17/15, 07:10

  3. Xavier Perseguers commented on patch set 2 V +1 CR +1 10/17/15, 07:14

    This targets TYPO3 6.2 but it happened in two of my installs for weeks and I never took time to debug until it went to my master install locally. Tiny change that we should definitely backport to 6.2 as well, because I’m certain it affects other non-power admins as well and they are lost, for sure
  4. Stefan Neufeind commented on patch set 2 CR +1 10/17/15, 19:25

    file_exists() is checked before anyway. So I don't see a big problem remove the @ here.
  5. Xavier Perseguers commented on patch set 2 CR +2 V +2 10/19/15, 08:32

    Backport from master, with rationale why it's needed in 6.2.
  6. Xavier Perseguers merged patch set 2 10/19/15, 08:32