Review main Merged

44123[TASK] Remove breakOnError option from wizard

Björn Jacob CR +2 V +2 Normal +52 −62 updated 11/03/15, 22:38

Commit message

The validation option "breakOnError" is not supported anymore. The
option has been removed completely during the rewrite.
The patch also provides the missing documentation for the
breaking change. The documentation itself will be touched by 
a differnt patch.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Daniel Goerz +1
    • Wouter Wolters +1
    • Michael Oehlhof +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 26

Show 6 more files

Review log 12

  1. Björn Jacob uploaded patch set 1 10/17/15, 09:10

  2. Stefan Neufeind commented on patch set 1 10/17/15, 22:25

    mentioned in some more additional places, like typo3/sysext/form/Documentation/Administration/Index.rst
  3. Björn Jacob updated the commit message in patch set 2 10/18/15, 05:59

  4. Björn Jacob commented on patch set 2 10/18/15, 06:00

    Thx. Since we have to provide a new documentation I did not want to touch the worthless documentation. There is an own issue for that.
  5. Stefan Neufeind voted on patch set 2 CR +1 10/18/15, 08:13

  6. Daniel Goerz voted on patch set 2 CR +1 10/18/15, 16:34

  7. Wouter Wolters commented on patch set 2 CR -1 11/03/15, 21:09

    should be removed from documentation too. sysext/form/Documentation/Configuration/Reference/Functions/Index.rst sysext/form/Documentation/Administration/Index.rst
  8. Björn Jacob commented on patch set 2 11/03/15, 21:26

    Please see my comments above and commit msg. Documentation is a separate patch. Hope that is okay.
  9. Wouter Wolters voted on patch set 2 V +1 CR +1 11/03/15, 21:31

  10. Michael Oehlhof voted on patch set 2 CR +1 11/03/15, 21:44

  11. Christian Kuhn voted on patch set 2 CR +2 V +2 11/03/15, 22:38

  12. Christian Kuhn merged patch set 2 11/03/15, 22:38