Review main Merged

44133[BUGFIX] Edit wizard is working again

Michael Oehlhof CR +2 V +2 Easy +1 −1 updated 10/18/15, 16:40

Commit message

When editing a backend user and selecting a backend user group in the
select box, pressing the edit wizard icon resulted in the message:
"Please select one or more items in the list before you can edit."

With this patch the popup with the edit backend user group form appears.

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Neufeind +1
    • Daniel Goerz +1
  • Verified V +2
    • Markus Klein +2
    • Stefan Neufeind +1
    • Daniel Goerz +1

Issues 1

Files 1

Review log 7

  1. Michael Oehlhof uploaded patch set 1 10/17/15, 21:39

  2. Stefan Neufeind commented on patch set 1 V -1 10/17/15, 22:12

    jsfunc.tbe_editor.js:279

    But 1 returns what is selected in the left (of those two) select-boxes. Shouldn't it be the right select-box?
  3. Michael Oehlhof commented on patch set 1 10/17/15, 23:09

    jsfunc.tbe_editor.js:279 Reply

    That the item of left box is selected is right. Have a look at 7.5 or 6.2 to verify it.
  4. Stefan Neufeind commented on patch set 1 V +1 CR +1 10/17/15, 23:28

    Ack, thanks. I was under the impression the right side makes sense because those icons are on the right.
  5. Daniel Goerz voted on patch set 1 CR +1 V +1 10/18/15, 16:24

  6. Markus Klein voted on patch set 1 V +2 CR +2 10/18/15, 16:40

  7. Markus Klein merged patch set 1 10/18/15, 16:40