Review TYPO3_6-2 Merged

44134[TASK] Properly encode database input in Typo3DbQueryParser

Stephan Großberndt CR +2 V +2 Easy +9 −2 updated 10/20/15, 06:16

Commit message

Review

  • Code review CR +2
    • Stefan Neufeind +2
  • Verified V +2
    • Stefan Neufeind +2

Issues 1

Files 2

Review log 6

  1. Stephan Großberndt uploaded patch set 1 10/17/15, 22:47

  2. Mathias Brodala commented on patch set 1 10/19/15, 07:58

    Typo3DbQueryParserTest.php:388

    I'd at least verify that this is called with [42, 37] to turn this into an assertion.
  3. Stephan Großberndt commented on patch set 1 10/19/15, 09:59

    this is just a missing backport on the 6.2 branch.
  4. Stefan Neufeind commented on patch set 1 CR +2 V +2 10/20/15, 05:02

    Clean backport from master; unit-tests work.
  5. Stefan Neufeind merged patch set 1 10/20/15, 05:02

  6. Mathias Schreiber commented on patch set 2 10/20/15, 06:16

    FYI: please take extra care when backporting stuff to 6.2. We still need to support PHP 5.3 here, so the ::class syntax may not be used.