Review main Merged

44144[TASK] Show correct module action name in bookmark list

Michael Oehlhof CR +2 V +2 Easy +11 −4 updated 10/25/15, 13:22

Commit message

This patch includes the changes for the two modules "Backend user"
and "Scheduler" using the new displayName property of the ShortcutButton.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Daniel Goerz +1
  • Verified V +2
    • Stefan Neufeind +2
    • Daniel Goerz +1

Issues 1

Files 2

Review log 10

  1. Michael Oehlhof uploaded patch set 1 10/18/15, 22:01

  2. Stefan Neufeind commented on patch set 1 10/21/15, 00:12

    I tried to add a proper name to EXT:impexp/Classes/Controller/ImportExportController.php as well. It correctly resolved to a name and executes the new setDisplayName(). But still the resulting shortcut is jus tthe default "Shortcut". My adjusted source so far was: https://notes.typo3.org/p/44144-impexp-shortcutName
  3. Stefan Neufeind voted on patch set 1 CR +1 V +1 10/21/15, 21:18

  4. Stefan Neufeind commented on patch set 1 10/21/15, 21:19

    !!! remove this note before merging. Make sure 44065 is merged first then
  5. Stefan Neufeind commented on patch set 1 CR 0 V -1 10/23/15, 14:05

    Retestet this with current patch 44065. Imho it worked last time I tried. Now the bookmark is always named "Backend Users" no matter what functionName is chosen. The action-name seems to be "success" now and not "online" or so anymore.
  6. Stefan Neufeind updated the commit message in patch set 2 10/25/15, 11:53

  7. Stefan Neufeind commented on patch set 2 CR +1 V +1 10/25/15, 11:54

    re-tested. Removed remark in commit-msg to merge the other review before (it is in now).
  8. Daniel Goerz voted on patch set 2 CR +1 V +1 10/25/15, 12:01

  9. Stefan Neufeind voted on patch set 2 CR +2 V +2 10/25/15, 13:22

  10. Stefan Neufeind merged patch set 2 10/25/15, 13:22