44145[BUGFIX] FormDataProvider: Adjust pageTsConfig-path for default-language
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 5
-
Stefan Neufeind uploaded patch set 1 10/19/15, 01:27
-
Stefan Neufeind commented on patch set 1 10/19/15, 01:28
tsconfig as per documentation: https://docs.typo3.org/typo3cms/FrontendLocalizationGuide/BasicSetupOfALocalizedWebsite/DefiningTheDefaultLanguageFlag/ -
Christian Kuhn commented on patch set 1 CR -1 10/22/15, 10:50
did this really fix something for you??? you're on the wrong track here. the "properties" array is an artificial construct returned by getTSConfig, so this access is ok. with your other patch applied, $modSharedTSconfig is empty since the SelectItems provider does not properly hand over $pageId. But, this selectItems provider shouldn't use this TranslationConfigurationProvider at all, see my @todo from https://review.typo3.org/#/c/44146/ So: -1, current state of the patch actually introduces bugs. please change the "special" "language" handling properly after the other patch is in. -
Stefan Neufeind commented on patch set 1 CR -1 V -1 10/25/15, 18:23
Yes it did. But I can't get it to work for me either way (with or without the patch, with or without properties, in pageTS or userTS) :-( -
Stefan Neufeind abandoned the change 10/25/15, 18:23