Review main Merged

44187[BUGFIX] Fix FloatValidatorTest on Windows

Stephan Großberndt CR +2 V +2 Easy +2 −2 updated 10/22/15, 19:01

Commit message

Supply another locale as secondary choice to fix the failing unit test
FloatValidatorTest on Windows.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 7

  1. Stephan Großberndt uploaded patch set 1 10/20/15, 19:26

  2. Christian Kuhn updated the commit message in patch set 2 10/22/15, 16:12

  3. Christian Kuhn uploaded patch set 3 10/22/15, 16:19

  4. Christian Kuhn commented on patch set 3 CR +1 V +1 10/22/15, 16:19

    thx! this version fixes this darn test on my system, too ;)
  5. Wouter Wolters voted on patch set 3 V +2 CR +2 10/22/15, 16:34

  6. Wouter Wolters merged patch set 3 10/22/15, 16:34

  7. Stephan Großberndt commented on patch set 4 10/22/15, 19:01

    Why not for 6.2 too?