Review main Merged

44225[BUGFIX] Drag&Drop upload broken after PSR-7 change

Frans Saris CR +2 V +2 Easy +2 −6 updated 10/22/15, 14:31

Commit message

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Tymoteusz Motylewski +1

Issues 1

Files 2

Review log 8

  1. Frans Saris uploaded patch set 1 10/22/15, 13:48

  2. Wouter Wolters voted on patch set 1 CR +1 10/22/15, 13:51

  3. Andreas Kienast commented on patch set 1 10/22/15, 13:59

    FileController.php:230

    Is it on purpose you drop the redirect here?
  4. Frans Saris commented on patch set 1 10/22/15, 14:09

    FileController.php:230 Reply

    yes, didn't do a full check. But IMO this is not relevant here
  5. Tymoteusz Motylewski commented on patch set 1 V +1 10/22/15, 14:09

    solves the problem, but having the same question as Andreas
  6. Frans Saris commented on patch set 1 10/22/15, 14:23

    the redirect doesn't make sense in ajax context
  7. Markus Klein commented on patch set 1 CR +2 V +2 10/22/15, 14:31

    I doublechecked on the redirect and couldn't find a usage in an ajax context, so this seems fine.
  8. Markus Klein merged patch set 1 10/22/15, 14:31