Review main Merged

44252[BUGFIX] Respect TSConfig in Language Diff View

Mathias Schreiber CR +2 V +2 Easy +4 −2 updated 10/25/15, 11:21

Commit message

In order to get the configured value from TSConfig to show in the
DiffView we need to provide the pid of the defaultLanguageRecord
to FormEngine.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Daniel Goerz +1
  • Verified V +2
    • Stefan Neufeind +2
    • Daniel Goerz +1

Issues 1

Files 1

Review log 9

  1. Mathias Schreiber uploaded patch set 1 10/23/15, 17:35

  2. Christian Kuhn commented on patch set 1 10/23/15, 17:37

    will have a look at that tomorrow. basically i just wanna now if the processing in getProcessedValue() may trigger unwanted stuff now.
  3. Christian Kuhn voted on patch set 1 CR +1 V +1 10/24/15, 15:32

  4. Stefan Neufeind commented on patch set 1 10/24/15, 20:38

    please rewrap - just in case somebody pushes another update to this issue
  5. Stefan Neufeind uploaded patch set 2 10/24/15, 20:45

  6. Stefan Neufeind commented on patch set 2 V +1 CR +1 10/24/15, 20:48

    Just set a boolean param to true instead of 1 (unrelated change) and rewrapped the commit-msg. @Lolli: Function-wise unchanged. Please revote.

    SingleFieldContainer.php:323

    unrelated. But looking up the params I changed this to true since it's a boolean.
  7. Daniel Goerz voted on patch set 2 CR +1 V +1 10/25/15, 11:01

  8. Stefan Neufeind commented on patch set 2 CR +2 V +2 10/25/15, 11:21

    also +1/+1 from Lolli still stands
  9. Stefan Neufeind merged patch set 2 10/25/15, 11:21