44276[TASK] Add default page setup on new installations
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Wouter Wolters +1
- Gernot Schulmeister +1
-
Verified V +2
- Frank Nägler +2
- Gernot Schulmeister +1
Issues 1
Files 2
Review log 27
Show 2 earlier messages
-
Georg Ringer voted on patch set 2 CR +1 V +1 10/30/15, 04:50
-
Andreas Kienast commented on patch set 2 10/30/15, 07:11
-
Benni Mack uploaded patch set 3 10/30/15, 07:43
-
Benni Mack updated the commit message in patch set 4 10/30/15, 08:08
-
Markus Sommer uploaded patch set 5 10/30/15, 11:15
-
Markus Sommer commented on patch set 5 CR +1 V +1 10/30/15, 11:17
Works Perfect, Only we have a break in the radio buttons. Resolved by deleted class for "width" -
Michael Oehlhof commented on patch set 5 CR +1 10/30/15, 12:10
DefaultConfiguration.php:51Maybe a space between PID and 1 The pages record is created for PID=0 so it must be "PID 0" instead of "PID 1"DefaultConfiguration.html:37Maybe better readable: create an empty page as base to start from -
Frank Nägler commented on patch set 5 CR +1 10/30/15, 13:35
testing now -
Frank Nägler commented on patch set 5 10/30/15, 13:46
The default page is very pure and ugly, can we agree to make it little bit more pretty? I would take care if you like. Anyway no big markup and styles, but a bit more nicer would be cool. -
Benni Mack commented on patch set 5 10/30/15, 13:47
go ahead please. That was my plan to have a starting point. -
Frank Nägler commented on patch set 5 CR -1 10/30/15, 13:47
great, I will add some small optimizations and push a new set -
Frank Nägler uploaded patch set 6 10/30/15, 13:58
-
Frank Nägler commented on patch set 6 CR +1 V +1 10/30/15, 14:00
So, I added some simple stylings, added our logo and a backlink to typo3.org. I think it is simple but nice. Here is a screenshot: http://shots.naegler.hamburg/LCGI -
Wouter Wolters voted on patch set 6 CR +1 10/30/15, 14:07
-
Markus Klein commented on patch set 5 10/30/15, 14:15
DefaultConfiguration.php:86not needed as this is included by default -
Markus Klein commented on patch set 6 CR -1 10/30/15, 14:20
DefaultConfiguration.php:68not needed as this is included by default -
Markus Klein commented on patch set 6 10/30/15, 14:21
DefaultConfiguration.php:68Replysee also https://review.typo3.org/44400 -
Frank Nägler commented on patch set 6 10/30/15, 14:43
DefaultConfiguration.php:68Replyso, simple remove the value and add an empty string? -
Frank Nägler uploaded patch set 7 10/30/15, 15:17
-
Frank Nägler voted on patch set 7 CR +1 V +1 10/30/15, 16:23
-
Wouter Wolters voted on patch set 7 CR +1 10/30/15, 18:13
-
Gernot Schulmeister voted on patch set 7 CR +1 V +1 10/30/15, 18:44
-
Frank Nägler voted on patch set 7 CR +2 V +2 10/30/15, 19:03
-
Frank Nägler merged patch set 7 10/30/15, 19:03
-
Stephan Großberndt commented on patch set 8 12/17/17, 13:06
Post -1DefaultConfiguration.php:65This introduced a bug as 31 is the maximum value for permissions with 5 checkboxes.
DefaultConfiguration.php:94