Review main Merged

44276[TASK] Add default page setup on new installations

Benni Mack CR +2 V +2 Normal +75 −12 updated 12/17/17, 13:06

Commit message

Adds a page and a sys_template to the system
after installation, using Fluid Styled Content
by default.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Wouter Wolters +1
    • Gernot Schulmeister +1
  • Verified V +2
    • Frank Nägler +2
    • Gernot Schulmeister +1

Issues 1

Files 2

Review log 27

Show 2 earlier messages
  1. Benni Mack uploaded patch set 1 10/26/15, 06:11

  2. Benni Mack uploaded patch set 2 10/29/15, 23:55

  1. Georg Ringer voted on patch set 2 CR +1 V +1 10/30/15, 04:50

  2. Andreas Kienast commented on patch set 2 10/30/15, 07:11

    DefaultConfiguration.php:94

    Via what?
  3. Benni Mack uploaded patch set 3 10/30/15, 07:43

  4. Benni Mack updated the commit message in patch set 4 10/30/15, 08:08

  5. Markus Sommer uploaded patch set 5 10/30/15, 11:15

  6. Markus Sommer commented on patch set 5 CR +1 V +1 10/30/15, 11:17

    Works Perfect, Only we have a break in the radio buttons. Resolved by deleted class for "width"
  7. Michael Oehlhof commented on patch set 5 CR +1 10/30/15, 12:10

    DefaultConfiguration.php:51

    Maybe a space between PID and 1 The pages record is created for PID=0 so it must be "PID 0" instead of "PID 1"

    DefaultConfiguration.html:37

    Maybe better readable: create an empty page as base to start from
  8. Frank Nägler commented on patch set 5 CR +1 10/30/15, 13:35

    testing now
  9. Frank Nägler commented on patch set 5 10/30/15, 13:46

    The default page is very pure and ugly, can we agree to make it little bit more pretty? I would take care if you like. Anyway no big markup and styles, but a bit more nicer would be cool.
  10. Benni Mack commented on patch set 5 10/30/15, 13:47

    go ahead please. That was my plan to have a starting point.
  11. Frank Nägler commented on patch set 5 CR -1 10/30/15, 13:47

    great, I will add some small optimizations and push a new set
  12. Frank Nägler uploaded patch set 6 10/30/15, 13:58

  13. Frank Nägler commented on patch set 6 CR +1 V +1 10/30/15, 14:00

    So, I added some simple stylings, added our logo and a backlink to typo3.org. I think it is simple but nice. Here is a screenshot: http://shots.naegler.hamburg/LCGI
  14. Wouter Wolters voted on patch set 6 CR +1 10/30/15, 14:07

  15. Markus Klein commented on patch set 5 10/30/15, 14:15

    DefaultConfiguration.php:86

    not needed as this is included by default
  16. Markus Klein commented on patch set 6 CR -1 10/30/15, 14:20

    DefaultConfiguration.php:68

    not needed as this is included by default
  17. Markus Klein commented on patch set 6 10/30/15, 14:21

    DefaultConfiguration.php:68 Reply

  18. Frank Nägler commented on patch set 6 10/30/15, 14:43

    DefaultConfiguration.php:68 Reply

    so, simple remove the value and add an empty string?
  19. Frank Nägler uploaded patch set 7 10/30/15, 15:17

  20. Frank Nägler voted on patch set 7 CR +1 V +1 10/30/15, 16:23

  21. Wouter Wolters voted on patch set 7 CR +1 10/30/15, 18:13

  22. Gernot Schulmeister voted on patch set 7 CR +1 V +1 10/30/15, 18:44

  23. Frank Nägler voted on patch set 7 CR +2 V +2 10/30/15, 19:03

  24. Frank Nägler merged patch set 7 10/30/15, 19:03

  25. Stephan Großberndt commented on patch set 8 12/17/17, 13:06

    Post -1

    DefaultConfiguration.php:65

    This introduced a bug as 31 is the maximum value for permissions with 5 checkboxes.