Review main Merged

44280[TASK] Streamline inline form in view module

Frank Nägler CR +2 V +2 Easy +18 −13 updated 10/26/15, 13:23

Commit message

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Michael Oehlhof +1
    • Oliver Hader +1
  • Verified V +2
    • Anja Leichsenring +2
    • Michael Oehlhof +1

Issues 1

Files 1

Review log 7

  1. Frank Nägler uploaded patch set 1 10/26/15, 09:18

  2. Michael Oehlhof commented on patch set 1 V -1 10/26/15, 11:35

    It took to much space with the 2 drop down boxes vertical. Would be better to place them horizontally.
  3. Frank Nägler commented on patch set 1 10/26/15, 11:49

    The form is an inline-form: <form class="form-inline">...
  4. Michael Oehlhof commented on patch set 1 V +1 CR +1 10/26/15, 12:25

    A little bit bad that it consumes so much space. Maybe it can be optimized later.
  5. Oliver Hader voted on patch set 1 CR +1 10/26/15, 13:12

  6. Anja Leichsenring voted on patch set 1 CR +2 V +2 10/26/15, 13:23

  7. Anja Leichsenring merged patch set 1 10/26/15, 13:23