Review main Merged

44283[BUGFIX] Make icon color white for colored buttons

Frank Nägler CR +2 V +2 Normal +33 −136 updated 10/26/15, 13:27

Commit message

This patch set the icon color for colored buttons to white instead
of black. And fix it for the clipboard clear button.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Oliver Hader +1
    • Michael Oehlhof +1
  • Verified V +2
    • Anja Leichsenring +2
    • Oliver Hader +1
    • Michael Oehlhof +1

Issues 1

Files 3

Review log 7

  1. Frank Nägler uploaded patch set 1 10/26/15, 10:55

  2. Michael Oehlhof commented on patch set 1 V +1 CR -1 10/26/15, 11:23

    It looks like that there are more changes in the backend.css than the changes in the _element_buttons.less file.
  3. Frank Nägler commented on patch set 1 10/26/15, 11:43

    the additional changes ok, because in another patch a wrong CSS was comitted. The generated backend.css is ok.
  4. Michael Oehlhof voted on patch set 1 CR +1 10/26/15, 12:22

  5. Oliver Hader voted on patch set 1 CR +1 V +1 10/26/15, 13:20

  6. Anja Leichsenring voted on patch set 1 CR +2 V +2 10/26/15, 13:27

  7. Anja Leichsenring merged patch set 1 10/26/15, 13:27