Review main Merged

44289[TASK] Move access right parameters from BE to SYS configuration

Zsolt Molnar CR +2 V +2 Normal +135 −32 updated 10/28/15, 17:39

Commit message

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Stefan Neufeind +1
    • Zsolt Molnar +1
  • Verified V +2
    • Nicole Hummel +2
    • Stefan Neufeind +1
    • Zsolt Molnar +1

Issues 1

Files 14

Review log 25

  1. Zsolt Molnar uploaded patch set 1 10/26/15, 12:13

  2. Stefan Neufeind commented on patch set 1 CR -1 10/26/15, 12:22

    some missing occurences - on it
  3. Stefan Neufeind uploaded patch set 2 10/26/15, 12:26

  4. Stefan Neufeind commented on patch set 2 10/26/15, 12:29

    Do we use a silent migration to move the values over upon update? Do we need an Important-rst, just in case somebody might rely on those settings in their extension? (In my eyes they usually shouldn't - and I'd therefor not really consider it a breaking change.)

    GeneralUtilityTest.php:4288

    my editor broke those two during edit. imho let's play safe here.
  5. Zsolt Molnar commented on patch set 2 CR +1 10/26/15, 12:31

    that is strange, searched through the whole project with phpstorm and it missed those two lines.
  6. Oliver Hader updated the commit message in patch set 3 10/26/15, 13:11

  7. Oliver Hader commented on patch set 3 CR -1 10/26/15, 13:12

    There should be a RST file that is documenting that change
  8. Zsolt Molnar commented on patch set 2 10/26/15, 13:51

    could you help me how to create the RST file?
  9. Stefan Neufeind commented on patch set 3 10/26/15, 14:18

    There is a generator-tool at: https://forger.typo3.org/standard/rst For ideas what to write :-) see below typo3/sysext/core/Documentation/Changelog/master.
  10. Zsolt Molnar uploaded patch set 4 10/26/15, 14:28

  11. Mathias Schreiber commented on patch set 4 V -1 10/26/15, 15:04

    We will need an Upgrade Wiazrd for this change since it might break other installations. Nicole can/will take care about one later tonight (or you can try your luck on your own).
  12. Zsolt Molnar commented on patch set 4 10/26/15, 15:06

    unfortunately I have to leave now, however I would like to build it so if Nicole can/wont make it tonight. i will give a try tomorrow morning
  13. Stefan Neufeind commented on patch set 4 10/26/15, 15:08

    @Zsolt, General remark about the rst-generator in the forger-backend: It offers 4 categories and "Task" is not among them. So your rst should maybe have had "Important" or so. The generator will tell you a composed filename as well as all plaintext-data for the file. Then please don't rewrap text there, remove empty lines or whatever. I'm sure together with the upgrade-wizard we can take care of the rst-file in the next patchset as well ... no need for a separate push imho.
  14. Zsolt Molnar commented on patch set 4 10/26/15, 15:28

    @Stefan, you have right I have pushed the rst file before you sent me the generator's link.from now on will use just the generator
  15. Nicole Hummel uploaded patch set 5 10/26/15, 21:33

  16. Stefan Neufeind commented on patch set 5 CR +1 V +1 10/26/15, 22:12

    Verified that the wizard correctly migrates the parameters, that their values are as they were before (and not returned to default) used the system for some actions, read the source, ran the unittests ... looks fine imho.
  17. Zsolt Molnar uploaded patch set 6 10/27/15, 08:26

  18. Nicole Hummel commented on patch set 6 10/27/15, 14:22

    Important-36166-MoveAccessRightParametersFromBEToSYSConfiguration.rst:10

    A new Upgrade Wizard ensures the correct migrations of the settings.
  19. Stefan Neufeind uploaded patch set 7 10/27/15, 20:36

  20. Stefan Neufeind commented on patch set 7 CR +1 V +1 10/27/15, 20:37

    reapplying votes. adjusted rst as Nicole suggested.
  21. Nicole Hummel commented on patch set 7 CR +1 V +1 10/27/15, 20:57

    GeneralUtilityTest.php:4288

    was this change intended?
  22. Stefan Neufeind commented on patch set 7 10/27/15, 21:24

    GeneralUtilityTest.php:4288 Reply

    There were NUL- and BS-chars in there before. My editor failed on them and simply dropped them upon the next save. So I thought it might be a good idea to replace them.
  23. Zsolt Molnar voted on patch set 7 CR +1 V +1 10/28/15, 04:52

  24. Nicole Hummel voted on patch set 7 CR +2 V +2 10/28/15, 17:39

  25. Nicole Hummel merged patch set 7 10/28/15, 17:39