Review main Merged

44299[BUGFIX] Shortcut list now scrollable if containing more than 10 entries

Michael Oehlhof CR +2 V +2 Easy +16 −0 updated 10/30/15, 11:04

Commit message

Review

  • Code review CR +2
    • Frank Nägler +2
    • Stefan Neufeind +1
    • Gernot Schulmeister +1
    • Michael Oehlhof +1
  • Verified V +2
    • Frank Nägler +2
    • Stefan Neufeind +1
    • Gernot Schulmeister +1
    • Michael Oehlhof +1

Issues 1

Files 2

Review log 13

  1. Michael Oehlhof uploaded patch set 1 10/26/15, 17:55

  2. Michael Oehlhof commented on patch set 1 CR -1 10/26/15, 17:57

    Only backend.css, must add the less file later. Need this review item to present the TYPO3.Review box at the TYPO3 user group rhein ruhr today.
  3. Stefan Neufeind commented on patch set 1 10/26/15, 19:39

    in general looks okay. Shows 10 rows in the bookmark-list and then starts scrolling. Maybe use less-variables to calculate the height - you'll need to add it to the less anyway :-)
  4. Michael Oehlhof uploaded patch set 2 10/27/15, 23:44

  5. Stefan Neufeind uploaded patch set 3 10/28/15, 20:59

  6. Stefan Neufeind commented on patch set 3 CR +1 V +1 10/28/15, 21:01

    Correct value seems to be 270px. That's what my browser tells me and what I can also compute by hand (see less). I don't have the build-environment to rebuild the css from less-files here - but I hope the syntax should be right. Do we want a verbose explanation (like done here) in the less-file? Unfortunately we don't have vars for the 12px and line-height:1.5 it seems.
  7. Daniel Goerz commented on patch set 3 10/29/15, 11:18

    The scrollbar can overlapp the delete icons quite a lot. This is suboptimal. Added a screen to the ticket.
  8. Michael Oehlhof commented on patch set 3 CR +1 V +1 10/29/15, 11:37

    @Daniel: Which browser are you using? In Firefox with the padding it looks good. Added a screenshot to the ticket.
  9. Daniel Goerz commented on patch set 3 10/29/15, 11:40

    Firefox on Mac. But lets wait for Bennis opinion anyways.
  10. Michael Oehlhof commented on patch set 3 10/29/15, 11:41

    I also use Firefox on Mac.
  11. Gernot Schulmeister commented on patch set 3 CR +1 V +1 10/30/15, 10:36

    tested on windows with Chrome, Firefox and IE
  12. Frank Nägler voted on patch set 3 CR +2 V +2 10/30/15, 11:04

  13. Frank Nägler merged patch set 3 10/30/15, 11:04