Review TYPO3_6-2 Merged

44302[BUGFIX] Add class alias of class loader to alias map

Helmut Hummel CR +2 V +2 Easy +5 −2 updated 10/29/15, 11:39

Commit message

Instead of hardcoding the class_alias call to alias the Flow
class loader, we must use the class alias API,
which in turn triggers the integrated composer
class loader to properly establish the alias.

This avoids a fatal error in the install tool clear cache action
which calls Bootstrap::initializeClassLoader() twice.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Andreas Kienast +1
    • Nicole Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Nicole Hummel +1

Issues 2

Files 4

Review log 16

  1. Helmut Hummel uploaded patch set 1 10/26/15, 21:17

  2. Helmut Hummel commented on patch set 1 10/26/15, 21:18

    autoload_classmap.php:220

    unrelated, but result of the automated update of the committed class loading information
  3. Nicole Hummel voted on patch set 1 CR +1 10/26/15, 21:38

  4. Martin Helmich voted on patch set 1 CR +1 10/27/15, 08:15

  5. Nicole Hummel voted on patch set 1 V +1 10/27/15, 14:20

  6. Wouter Wolters voted on patch set 1 CR +1 10/28/15, 17:55

  7. Andreas Kienast updated the commit message in patch set 2 10/28/15, 18:56

  8. Andreas Kienast voted on patch set 2 CR +1 10/28/15, 18:56

  9. Stefan Neufeind commented on patch set 2 CR +1 10/28/15, 22:19

    But I couldn't reproduce the fatal you mentioned.
  10. Helmut Hummel commented on patch set 2 10/28/15, 22:43

    > I couldn't reproduce the fatal you mentioned. You are on latest 6.2 branch and cannot reproduce the fatal when using "clear caches" in install tool
  11. Stefan Neufeind commented on patch set 2 10/29/15, 00:05

    Yes, Helmut. Latest 6.2 without this patch, click on "clear all cache" in the install-tool => all fine
  12. Nicole Hummel voted on patch set 2 CR +1 V +1 10/29/15, 11:24

  13. Nicole Hummel commented on patch set 2 10/29/15, 11:25

    @Stefan/Helmut: is a composer install/update needed?
  14. Christian Kuhn voted on patch set 2 CR +2 V +2 10/29/15, 11:38

  15. Christian Kuhn merged patch set 2 10/29/15, 11:38

  16. Christian Kuhn commented on patch set 3 10/29/15, 11:39

    imho no composer install/update is needed.